Re: [dpdk-dev] [PATCH] cmdline: remove unnecessary #ifdef

2019-11-12 Thread David Marchand
On Tue, Nov 12, 2019 at 9:11 AM Olivier Matz wrote: > > On Fri, Nov 08, 2019 at 10:00:35AM -0800, Stephen Hemminger wrote: > > The #ifdef to conditionally include on BSD > > is unnecessary. It is harmless to include the header on other > > OS's. An extra include is better than an #ifdef. > > > >

Re: [dpdk-dev] [PATCH] cmdline: remove unnecessary #ifdef

2019-11-12 Thread Olivier Matz
On Fri, Nov 08, 2019 at 10:00:35AM -0800, Stephen Hemminger wrote: > The #ifdef to conditionally include on BSD > is unnecessary. It is harmless to include the header on other > OS's. An extra include is better than an #ifdef. > > Signed-off-by: Stephen Hemminger Acked-by: Olivier Matz Thanks

Re: [dpdk-dev] [PATCH] cmdline: remove unnecessary #ifdef

2019-11-11 Thread Bruce Richardson
On Fri, Nov 08, 2019 at 10:00:35AM -0800, Stephen Hemminger wrote: > The #ifdef to conditionally include on BSD > is unnecessary. It is harmless to include the header on other > OS's. An extra include is better than an #ifdef. > > Signed-off-by: Stephen Hemminger > --- > app/test-pmd/cmdline.c

[dpdk-dev] [PATCH] cmdline: remove unnecessary #ifdef

2019-11-08 Thread Stephen Hemminger
The #ifdef to conditionally include on BSD is unnecessary. It is harmless to include the header on other OS's. An extra include is better than an #ifdef. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c| 2 -- app/test/test_cmdline_ipaddr.c| 2 -- lib/