[dpdk-dev] [PATCH] cmdline: fix unchecked return value

2016-07-01 Thread Olivier MATZ
Hi Daniel, >>> --- a/lib/librte_cmdline/cmdline_rdline.c >>> +++ b/lib/librte_cmdline/cmdline_rdline.c >>> @@ -377,7 +377,10 @@ rdline_char_in(struct rdline *rdl, char c) >>> case CMDLINE_KEY_CTRL_K: >>> cirbuf_get_buf_head(&rdl->right, rdl->kill_buf, >> RDLINE_BUF_

[dpdk-dev] [PATCH] cmdline: fix unchecked return value

2016-06-28 Thread Mrzyglod, DanielX T
>From: Olivier Matz [mailto:olivier.matz at 6wind.com] >Sent: Monday, May 02, 2016 3:37 PM >To: Mrzyglod, DanielX T ; dev at dpdk.org >Subject: Re: [PATCH] cmdline: fix unchecked return value > >Hi Daniel, > >On 04/14/2016 03:01 PM, Daniel Mrzyglod wrote: >> This patch is for checking if error valu

[dpdk-dev] [PATCH] cmdline: fix unchecked return value

2016-05-02 Thread Olivier Matz
Hi Daniel, On 04/14/2016 03:01 PM, Daniel Mrzyglod wrote: > This patch is for checking if error values occurs. > fix for coverity errors #13209 & #13195 > > If the function returns an error value, the error value may be mistaken > for a normal value. > > In rdline_char_in: Value returned from a

[dpdk-dev] [PATCH] cmdline: fix unchecked return value

2016-04-14 Thread Daniel Mrzyglod
This patch is for checking if error values occurs. fix for coverity errors #13209 & #13195 If the function returns an error value, the error value may be mistaken for a normal value. In rdline_char_in: Value returned from a function is not checked for errors before being used Signed-off-by: Dani