Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice

2018-11-11 Thread Thomas Monjalon
07/11/2018 18:46, Zhang, Qi Z: > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > On Wed, Nov 07, 2018 at 04:53:50PM +, Zhang, Qi Z wrote: > > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > > > On Tue, Nov 06, 2018 at 09:36:22PM +0100, Thomas Monjalon wrote: > > > > > 06/11/2018

Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice

2018-11-07 Thread Zhang, Qi Z
> -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Wednesday, November 7, 2018 10:15 AM > To: Zhang, Qi Z > Cc: Thomas Monjalon ; dev@dpdk.org; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twic

Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice

2018-11-07 Thread Gaëtan Rivet
; Yigit, Ferruh > > > > Subject: Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice > > > > On Tue, Nov 06, 2018 at 09:36:22PM +0100, Thomas Monjalon wrote: > > > 06/11/2018 16:46, Zhang, Qi Z: > > > > From: Thomas Monjalon [mailto:tho...@mon

Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice

2018-11-07 Thread Zhang, Qi Z
> -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Tuesday, November 6, 2018 4:34 PM > To: Thomas Monjalon > Cc: Zhang, Qi Z ; dev@dpdk.org; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice >

Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice

2018-11-06 Thread Gaëtan Rivet
On Tue, Nov 06, 2018 at 09:36:22PM +0100, Thomas Monjalon wrote: > 06/11/2018 16:46, Zhang, Qi Z: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > > Hi, > > > > > > 06/11/2018 01:31, Qi Zhang: > > > > When probe the same device at second time > > > > > > Sorry I stop on this firs

Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice

2018-11-06 Thread Thomas Monjalon
06/11/2018 16:46, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > Hi, > > > > 06/11/2018 01:31, Qi Zhang: > > > When probe the same device at second time > > > > Sorry I stop on this first sentence. > > How and why do you probe a vdev twice? > > if we do rte_dev_hotplu

Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice

2018-11-06 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, November 6, 2018 2:01 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; gaetan.ri...@6wind.com; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twic

Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice

2018-11-06 Thread Thomas Monjalon
Hi, 06/11/2018 01:31, Qi Zhang: > When probe the same device at second time Sorry I stop on this first sentence. How and why do you probe a vdev twice?

Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice

2018-11-06 Thread Gaëtan Rivet
Hi, On Tue, Nov 06, 2018 at 08:31:50AM +0800, Qi Zhang wrote: > When probe the same device at second time, devargs will be > replaced in devargs_list, old version is destoried but they > are still referenced by vdev->device. So we break the link > between vdev->device to devargs_list by clone, and

[dpdk-dev] [PATCH] bus/vdev: fix probe same device twice

2018-11-05 Thread Qi Zhang
When probe the same device at second time, devargs will be replaced in devargs_list, old version is destoried but they are still referenced by vdev->device. So we break the link between vdev->device to devargs_list by clone, and the copy one will be freed by vdev bus itself. Signed-off-by: Qi Zhan