Re: [dpdk-dev] [PATCH] bus/fslmc: update MC to 10.3.x

2017-10-06 Thread Shreyansh Jain
Hello Thomas, On Friday 06 October 2017 05:04 AM, Thomas Monjalon wrote: Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal This is a huge patch without any comment! It will be hard to find bugs in it when debugging in future. And it will be also pointless to reference it in future

Re: [dpdk-dev] [PATCH] bus/fslmc: update MC to 10.3.x

2017-10-05 Thread Thomas Monjalon
> Signed-off-by: Shreyansh Jain > Signed-off-by: Hemant Agrawal This is a huge patch without any comment! It will be hard to find bugs in it when debugging in future. And it will be also pointless to reference it in future fixes. >From a quality point of view, it is bad. As it is touching only