Re: [dpdk-dev] [PATCH] bus/fslmc: drop inline from non-static functions

2020-05-20 Thread David Marchand
On Wed, May 20, 2020 at 12:22 PM Ferruh Yigit wrote: > > There is no point in having non-static (and non-extern) inline > functions. > > Also this breaks the build for the ICC [1] because of the 'internal' > symbol check. > > When function is 'inline' ICC is ignoring 'section' attribute and not >

Re: [dpdk-dev] [PATCH] bus/fslmc: drop inline from non-static functions

2020-05-20 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

[dpdk-dev] [PATCH] bus/fslmc: drop inline from non-static functions

2020-05-20 Thread Ferruh Yigit
There is no point in having non-static (and non-extern) inline functions. Also this breaks the build for the ICC [1] because of the 'internal' symbol check. When function is 'inline' ICC is ignoring 'section' attribute and not putting function to 'internal' section which breaks 'check-symbols.sh'