Re: [dpdk-dev] [PATCH] bus/dpaa: optimize device name parsing

2020-11-09 Thread Gaëtan Rivet
On 09/11/20 12:58 +0100, David Marchand wrote: > On Mon, Nov 9, 2020 at 12:32 PM Gaetan Rivet wrote: > > + delta = 0; > > + if (strncmp(name, "dpaa_bus:", 9) == 0) { > > + delta = 9; > > + } else if (strncmp(name, "name=", 5) == 0) { > > + delta = 5; >

Re: [dpdk-dev] [PATCH] bus/dpaa: optimize device name parsing

2020-11-09 Thread David Marchand
On Mon, Nov 9, 2020 at 12:32 PM Gaetan Rivet wrote: > + delta = 0; > + if (strncmp(name, "dpaa_bus:", 9) == 0) { > + delta = 9; > + } else if (strncmp(name, "name=", 5) == 0) { > + delta = 5; > + } > + > + if (sscanf(&name[delta], "fm%u-mac

Re: [dpdk-dev] [PATCH] bus/dpaa: optimize device name parsing

2020-11-09 Thread Gaëtan Rivet
On 09/11/20 12:31 +0100, Gaetan Rivet wrote: > Device name parsing is done on all buses during device iterations at > either EAL or ethdev levels. > > When a bus implements device name parsing slowly, all iterations are > impacted. Efficient implementation is important. > > The DPAA bus device na

[dpdk-dev] [PATCH] bus/dpaa: optimize device name parsing

2020-11-09 Thread Gaetan Rivet
Device name parsing is done on all buses during device iterations at either EAL or ethdev levels. When a bus implements device name parsing slowly, all iterations are impacted. Efficient implementation is important. The DPAA bus device name parsing has two issues: it allocates dynamic memory and