Re: [dpdk-dev] [PATCH] build: list symbols exports in a single file

2021-04-07 Thread Kinsella, Ray
On 06/04/2021 17:50, Bruce Richardson wrote: > On Tue, Apr 06, 2021 at 06:32:30PM +0200, David Marchand wrote: >> Rather than have two files that keeps getting out of sync, let's >> annotate the version.map to generate the Windows export file. >> >> Note: EAL version.map annotation achieved with

Re: [dpdk-dev] [PATCH] build: list symbols exports in a single file

2021-04-06 Thread David Marchand
On Tue, Apr 6, 2021 at 6:51 PM Bruce Richardson wrote: > > -# special case, allow override if an def file already exists alongside map > > file > > -override_file = join(dirname(args[1]), basename(args[2])) > > -if exists(override_file): > > -with open(override_file) as f_in: > >

Re: [dpdk-dev] [PATCH] build: list symbols exports in a single file

2021-04-06 Thread Bruce Richardson
On Tue, Apr 06, 2021 at 06:32:30PM +0200, David Marchand wrote: > Rather than have two files that keeps getting out of sync, let's > annotate the version.map to generate the Windows export file. > > Note: EAL version.map annotation achieved with: > $ ./buildtools/map-list-symbol.sh lib/librte_eal/

Re: [dpdk-dev] [PATCH] build: list symbols exports in a single file

2021-04-06 Thread David Marchand
On Tue, Apr 6, 2021 at 6:33 PM David Marchand wrote: > diff --git a/buildtools/map_to_win.py b/buildtools/map_to_win.py > index 2a6cb88605..34434d96fa 100644 > --- a/buildtools/map_to_win.py > +++ b/buildtools/map_to_win.py > @@ -7,7 +7,7 @@ > > > def is_function_line(ln): > -return ln.starts

[dpdk-dev] [PATCH] build: list symbols exports in a single file

2021-04-06 Thread David Marchand
Rather than have two files that keeps getting out of sync, let's annotate the version.map to generate the Windows export file. Note: EAL version.map annotation achieved with: $ ./buildtools/map-list-symbol.sh lib/librte_eal/version.map | while read file version sym; do ! git grep -qw $sym li