Re: [dpdk-dev] [PATCH] app/testpmd: move variables definition in source

2018-01-31 Thread Thomas Monjalon
24/01/2018 12:53, Georgios P. Katsikas: > From: Georgios Katsikas > > This patch moves the definition of 3 variables in testpmd.h > into the respective .c file. The idea behind this move is > to allow external applications to compile against testpmd > without throwing compilation errors related t

Re: [dpdk-dev] [PATCH] app/testpmd: move variables definition in source

2018-01-30 Thread Georgios Katsikas
Hi, This is a kind reminder to review this short patch. There seems to be 1 build failure out of 15, but the error looks irrelevant to the patch according to: http://dpdk.org/dev/patchwork/patch/34403/ Please let me know if there is something I could fix. Best regards, Georgios On Wed, Jan 24, 2

[dpdk-dev] [PATCH] app/testpmd: move variables definition in source

2018-01-24 Thread Georgios P. Katsikas
From: Georgios Katsikas This patch moves the definition of 3 variables in testpmd.h into the respective .c file. The idea behind this move is to allow external applications to compile against testpmd without throwing compilation errors related to multiple definition of variables. Also, an extern