Re: [dpdk-dev] [PATCH] app/testpmd: fix wrong return value in parse_port_list

2020-02-20 Thread Iremonger, Bernard
Hi Hariprasad, > -Original Message- > From: Govindharajan, Hariprasad > Sent: Thursday, February 20, 2020 1:27 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; Yigit, Ferruh ; > step...@networkplumber.org; david.march...@redhat.com; > Govindharajan, Haripr

[dpdk-dev] [PATCH] app/testpmd: fix wrong return value in parse_port_list

2020-02-20 Thread Hariprasad Govindharajan
The function parse_port_list() is designed to return unsigned int value. After sanitizing the inputs, it is returning -1. Changed it to return 0. Fixes: 2df00d562d20 ("app/testpmd: add --portlist option") Cc: hariprasad.govindhara...@intel.com Signed-off-by: Hariprasad Govindharajan --- app/tes

Re: [dpdk-dev] [PATCH] app/testpmd: fix wrong return value

2019-09-30 Thread Ferruh Yigit
On 9/30/2019 9:23 AM, Ye Xiaolong wrote: > On 09/29, Qi Zhang wrote: >> The patch fix the issue that return value in parse_vc_action_rss >> be overwritten unexpectly. That cause an rte_flow creation command >> with rss action does not work. >> >> For example: >> >> testpmd> flow create 0 ingress pa

Re: [dpdk-dev] [PATCH] app/testpmd: fix wrong return value

2019-09-30 Thread Ye Xiaolong
On 09/29, Qi Zhang wrote: >The patch fix the issue that return value in parse_vc_action_rss >be overwritten unexpectly. That cause an rte_flow creation command >with rss action does not work. > >For example: > >testpmd> flow create 0 ingress pattern eth / ipv4 / end \ >actions rss types ipv4 end /

[dpdk-dev] [PATCH] app/testpmd: fix wrong return value

2019-09-28 Thread Qi Zhang
The patch fix the issue that return value in parse_vc_action_rss be overwritten unexpectly. That cause an rte_flow creation command with rss action does not work. For example: testpmd> flow create 0 ingress pattern eth / ipv4 / end \ actions rss types ipv4 end / end We will get error "Bad Agumen