Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

2019-07-02 Thread Ferruh Yigit
g >>> Cc: sta...@dpdk.org >>> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error >>> >>> On 6/11/2019 2:28 AM, Zhao1, Wei wrote: >>>> Hi, Kevin Traynor >>>>This patch is based on Yigit Ferruh's suggestio

Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

2019-07-02 Thread Ferruh Yigit
On 6/12/2019 2:04 AM, Zhao1, Wei wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Tuesday, June 11, 2019 10:42 PM >> To: Zhao1, Wei ; Kevin Traynor >> ; dev@dpdk.org >> Cc: sta...@dpdk.org >> Subject: Re: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

2019-06-11 Thread Zhao1, Wei
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, June 11, 2019 10:42 PM > To: Zhao1, Wei ; Kevin Traynor > ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error > > On 6/11/2019 2:28 A

Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

2019-06-11 Thread Ferruh Yigit
gt;> Sent: Monday, June 10, 2019 6:10 PM >> To: Zhao1, Wei ; dev@dpdk.org >> Cc: sta...@dpdk.org; Yigit, Ferruh >> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error >> >> On 10/06/2019 07:45, Wei Zhao wrote: >>> There is no need to us

Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

2019-06-10 Thread Zhao1, Wei
6:10 PM > > To: Zhao1, Wei ; dev@dpdk.org > > Cc: sta...@dpdk.org; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set > > error > > > > On 10/06/2019 07:45, Wei Zhao wrote: > > > There is no need to use default offloads

Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

2019-06-10 Thread Zhao1, Wei
ot;or" for offloads. Hello Ferruh,What is your comment? > -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Monday, June 10, 2019 6:10 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH] app/

Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

2019-06-10 Thread Kevin Traynor
On 10/06/2019 07:45, Wei Zhao wrote: > There is no need to use default offloads configuration > if offloads configuration has been pass down from uplayer. > It doesn't seem like the right fix to me. It means if a user enable/disable one offload in the command line they are silently changing from

[dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

2019-06-10 Thread Wei Zhao
There is no need to use default offloads configuration if offloads configuration has been pass down from uplayer. Fixes: 5e91aeef218c ("app/testpmd: fix offload flags after port config") Signed-off-by: Wei Zhao --- app/test-pmd/testpmd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(