Re: [dpdk-dev] [PATCH] app/testpmd: fix mpls encap ipv4 version and ihl

On 12/25/2018 7:29 PM, Rami Rosen wrote: > Hi Saleh, > Thanks for your patch. > If you will grep into the DPDK repo you will see that there are several > occurrences of IP_VHL_DEF, with the same functionality. > I would consider putting the IPV4_VHL_DEF you added in a more generic > location and no

Re: [dpdk-dev] [PATCH] app/testpmd: fix mpls encap ipv4 version and ihl

Hi Saleh, Thanks for your patch. If you will grep into the DPDK repo you will see that there are several occurrences of IP_VHL_DEF, with the same functionality. I would consider putting the IPV4_VHL_DEF you added in a more generic location and not under testpmd, so other modules will be able to use

[dpdk-dev] [PATCH] app/testpmd: fix mpls encap ipv4 version and ihl

According to ietf rfc791 (see [1]) "The Version field indicates the format of the internet header."     "Internet Header Length (ihl) is the length of the     internet header in 32 bit words, and thus points     to the beginning of the data. Note that     the minimum value for a correct h