Re: [dpdk-dev] [PATCH] app/testpmd: fix hotplug

2020-01-23 Thread Ferruh Yigit
On 1/23/2020 5:46 PM, Iremonger, Bernard wrote: > Hi Ferruh, > >> >> > Subject: [PATCH] app/testpmd: fix hotplug > This is reverting the original patch, which breaks hotplug. I think the commit message should make this clear. This patch is not fixing hotplug, the original p

Re: [dpdk-dev] [PATCH] app/testpmd: fix hotplug

2020-01-23 Thread Iremonger, Bernard
Hi Ferruh, > > > > >> Subject: [PATCH] app/testpmd: fix hotplug > > >> > > > This is reverting the original patch, which breaks hotplug. > > > I think the commit message should make this clear. > > > This patch is not fixing hotplug, the original patch seems to have > > > revealed a > > problem

Re: [dpdk-dev] [PATCH] app/testpmd: fix hotplug

2020-01-23 Thread Iremonger, Bernard
Hi Ferruh, > >> Subject: [PATCH] app/testpmd: fix hotplug > >> > > This is reverting the original patch, which breaks hotplug. > > I think the commit message should make this clear. > > This patch is not fixing hotplug, the original patch seems to have revealed > > a > problem with hotplug. > >

Re: [dpdk-dev] [PATCH] app/testpmd: fix hotplug

2020-01-23 Thread Ferruh Yigit
On 1/23/2020 5:01 PM, Iremonger, Bernard wrote: > Hi Ferruh, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Thursday, January 23, 2020 3:15 PM >> To: Lu, Wenzhuo ; Wu, Jingjing >> ; Iremonger, Bernard >> ; Matan Azrad >> Cc: dev@dpdk.org; sta...@dpdk.org >> Subject: [PATCH] app/

Re: [dpdk-dev] [PATCH] app/testpmd: fix hotplug

2020-01-23 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, January 23, 2020 3:15 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; Matan Azrad > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] app/testpmd: fix hotplug > This is reverting the original patch

Re: [dpdk-dev] [PATCH] app/testpmd: fix hotplug

2020-01-23 Thread Matan Azrad
Hi From: Ferruh Yigit > The 'port_id_is_invalid()' check in the 'detach_port_device()' is breaking the > hotplug support, since at that stage port will be closed and validity check > always fail [1] and removing the device is not really completed. > > But this cause the vfio request interrupt k

[dpdk-dev] [PATCH] app/testpmd: fix hotplug

2020-01-23 Thread Ferruh Yigit
The 'port_id_is_invalid()' check in the 'detach_port_device()' is breaking the hotplug support, since at that stage port will be closed and validity check always fail [1] and removing the device is not really completed. But this cause the vfio request interrupt keep triggered continuously and make