Re: [dpdk-dev] [PATCH] app/testpmd: fix failsafe PMD failure on exit

2018-06-01 Thread Yuanhan Liu
On Sun, May 27, 2018 at 02:37:28PM +0200, Thomas Monjalon wrote: > 27/05/2018 06:06, Yuanhan Liu: > > On Tue, May 22, 2018 at 07:35:08PM +0100, Ferruh Yigit wrote: > > > + /* > > > + * This is a workaround to fix a virtio-user issue that > > > + * r

Re: [dpdk-dev] [PATCH] app/testpmd: fix failsafe PMD failure on exit

2018-05-27 Thread Thomas Monjalon
27/05/2018 06:06, Yuanhan Liu: > On Tue, May 22, 2018 at 07:35:08PM +0100, Ferruh Yigit wrote: > > + /* > > +* This is a workaround to fix a virtio-user issue that > > +* requires to call clean-up routine to remove existing > > +

Re: [dpdk-dev] [PATCH] app/testpmd: fix failsafe PMD failure on exit

2018-05-26 Thread Yuanhan Liu
On Tue, May 22, 2018 at 07:35:08PM +0100, Ferruh Yigit wrote: > vdevs detach on testpmd exit implemented as workaround to fix > a virtio-user issue. The issue was virtio-user cleanup is not > called and existing socket file not cleaned up which will fail > next run. > > The vdev cleanup causing pr

Re: [dpdk-dev] [PATCH] app/testpmd: fix failsafe PMD failure on exit

2018-05-22 Thread Ferruh Yigit
On 5/22/2018 9:49 PM, Ferruh Yigit wrote: > On 5/22/2018 8:47 PM, Thomas Monjalon wrote: >> 22/05/2018 20:35, Ferruh Yigit: >>> vdevs detach on testpmd exit implemented as workaround to fix >>> a virtio-user issue. The issue was virtio-user cleanup is not >>> called and existing socket file not cle

Re: [dpdk-dev] [PATCH] app/testpmd: fix failsafe PMD failure on exit

2018-05-22 Thread Ferruh Yigit
On 5/22/2018 8:47 PM, Thomas Monjalon wrote: > 22/05/2018 20:35, Ferruh Yigit: >> vdevs detach on testpmd exit implemented as workaround to fix >> a virtio-user issue. The issue was virtio-user cleanup is not >> called and existing socket file not cleaned up which will fail >> next run. >> >> The v

Re: [dpdk-dev] [PATCH] app/testpmd: fix failsafe PMD failure on exit

2018-05-22 Thread Thomas Monjalon
22/05/2018 20:35, Ferruh Yigit: > vdevs detach on testpmd exit implemented as workaround to fix > a virtio-user issue. The issue was virtio-user cleanup is not > called and existing socket file not cleaned up which will fail > next run. > > The vdev cleanup causing problems in failsafe PMD. > > R

[dpdk-dev] [PATCH] app/testpmd: fix failsafe PMD failure on exit

2018-05-22 Thread Ferruh Yigit
vdevs detach on testpmd exit implemented as workaround to fix a virtio-user issue. The issue was virtio-user cleanup is not called and existing socket file not cleaned up which will fail next run. The vdev cleanup causing problems in failsafe PMD. Reduce the cleanup to only virtio-user and add a