Re: [dpdk-dev] [PATCH] app/testpmd: fix failing to enable SW checksum calculation

2018-01-31 Thread Thomas Monjalon
25/01/2018 07:54, Shahaf Shuler: > Hi Jiayu Hu, > > Good fix, thanks. > > Thursday, January 25, 2018 4:14 AM, Jiayu Hu: > > In current design, we can't enable SW checksum calculation for the devices > > which don't have checksum offloading abilities via the command "csum set > > ip|tcp|udp|sctp|o

Re: [dpdk-dev] [PATCH] app/testpmd: fix failing to enable SW checksum calculation

2018-01-24 Thread Shahaf Shuler
Hi Jiayu Hu, Good fix, thanks. Thursday, January 25, 2018 4:14 AM, Jiayu Hu: > In current design, we can't enable SW checksum calculation for the devices > which don't have checksum offloading abilities via the command "csum set > ip|tcp|udp|sctp|outer-ip sw ". > But SW checksum calculation shoul

Re: [dpdk-dev] [PATCH] app/testpmd: fix failing to enable SW checksum calculation

2018-01-24 Thread Hu, Jiayu
> -Original Message- > From: Lu, Wenzhuo > Sent: Thursday, January 25, 2018 10:58 AM > To: Hu, Jiayu ; dev@dpdk.org > Cc: shah...@mellanox.com; Yao, Lei A > Subject: RE: [PATCH] app/testpmd: fix failing to enable SW checksum > calculation > > Hi Jiayu, > > > > -Original Message---

Re: [dpdk-dev] [PATCH] app/testpmd: fix failing to enable SW checksum calculation

2018-01-24 Thread Hu, Jiayu
Hi Wenzhuo, > -Original Message- > From: Lu, Wenzhuo > Sent: Thursday, January 25, 2018 10:58 AM > To: Hu, Jiayu ; dev@dpdk.org > Cc: shah...@mellanox.com; Yao, Lei A > Subject: RE: [PATCH] app/testpmd: fix failing to enable SW checksum > calculation > > Hi Jiayu, > > > > -Original

Re: [dpdk-dev] [PATCH] app/testpmd: fix failing to enable SW checksum calculation

2018-01-24 Thread Lu, Wenzhuo
Hi Jiayu, > -Original Message- > From: Hu, Jiayu > Sent: Thursday, January 25, 2018 10:14 AM > To: dev@dpdk.org > Cc: shah...@mellanox.com; Lu, Wenzhuo ; Yao, Lei > A ; Hu, Jiayu > Subject: [PATCH] app/testpmd: fix failing to enable SW checksum calculation > > In current design, we can'

[dpdk-dev] [PATCH] app/testpmd: fix failing to enable SW checksum calculation

2018-01-24 Thread Jiayu Hu
In current design, we can't enable SW checksum calculation for the devices which don't have checksum offloading abilities via the command "csum set ip|tcp|udp|sctp|outer-ip sw ". But SW checksum calculation shouldn't depend on HW offloading abilities. This patch is to fix this issue. Fixes: 3926dd