Re: [dpdk-dev] [PATCH] app/testpmd: fix crash

2019-06-16 Thread Thomas Monjalon
14/06/2019 20:19, Ferruh Yigit: > Testpmd tries to calculate mbuf size based on "max Rx packet size" and > "max MTU segment number". > When driver set a "nb_mtu_seg_max" to zero, it causes division by zero > segmentation fault in testpmd. > > If the PMD set "nb_mtu_seg_max" to zero, testpmd should

[dpdk-dev] [PATCH] app/testpmd: fix crash

2019-06-14 Thread Ferruh Yigit
Testpmd tries to calculate mbuf size based on "max Rx packet size" and "max MTU segment number". When driver set a "nb_mtu_seg_max" to zero, it causes division by zero segmentation fault in testpmd. If the PMD set "nb_mtu_seg_max" to zero, testpmd shouldn't try to calculate the mbuf size. Fixes:

Re: [dpdk-dev] [PATCH] app/testpmd: fix crash when doing port info of vdev

2019-04-09 Thread Stephen Hemminger
On Fri, 15 Feb 2019 17:36:46 -0800 Stephen Hemminger wrote: > From: Stephen Hemminger > > Noticed a SEGV in testpmd doing: > > show port info 1 > on Hyper-V with failsafe/tap PMD. > > A vdev may not have an associated device (i.e NULL) and therefore > testpmd should skip devargs in that cas

Re: [dpdk-dev] [PATCH] app/testpmd: fix crash when doing port info of vdev

2019-02-17 Thread Wu, Jingjing
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Saturday, February 16, 2019 9:37 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Stephen Hemminger > Subject: [dpdk-dev] [PATCH] app/testpmd: fix crash when doing po

[dpdk-dev] [PATCH] app/testpmd: fix crash when doing port info of vdev

2019-02-15 Thread Stephen Hemminger
From: Stephen Hemminger Noticed a SEGV in testpmd doing: > show port info 1 on Hyper-V with failsafe/tap PMD. A vdev may not have an associated device (i.e NULL) and therefore testpmd should skip devargs in that case. Fixes: cf72ed09181b ("app/testpmd: display devargs in port info output") Sig

Re: [dpdk-dev] [PATCH] app/testpmd: fix crash when attaching a device

2018-06-14 Thread Iremonger, Bernard
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Wednesday, June 13, 2018 5:28 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; sta...@dpdk.org; Singh, Jasvinder > ; Xueming(steven) Li > > Subject: [PATCH] app/tes

[dpdk-dev] [PATCH] app/testpmd: fix crash when attaching a device

2018-06-13 Thread Adrien Mazarguil
Below commit checks global device information to determine if a port uses the softnic driver once initialized. Problem is that this information is not available at this point when a port is initialized interactively through a "port attach XXX" command, crashing testpmd. This patch systematically i

Re: [dpdk-dev] [PATCH] app/testpmd: fix crash of txonly with multiple segments

2018-01-09 Thread Thomas Monjalon
> > Running txonly mode can crash with "--txpkts=20,470". copy_len should be > > properly adjusted. > > > > Fixes: af75078fece3 ("first public release") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Yongseok Koh > Acked-by: Wenzhuo Lu Applied, thanks

Re: [dpdk-dev] [PATCH] app/testpmd: fix crash of txonly with multiple segments

2018-01-04 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yongseok Koh > Sent: Wednesday, December 27, 2017 11:52 AM > To: Wu, Jingjing > Cc: dev@dpdk.org; Yongseok Koh ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] app/testpmd: fix crash of tx

[dpdk-dev] [PATCH] app/testpmd: fix crash of txonly with multiple segments

2017-12-26 Thread Yongseok Koh
Running txonly mode can crash with "--txpkts=20,470". copy_len should be properly adjusted. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- app/test-pmd/txonly.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/txonly.c b/app/test

[dpdk-dev] [PATCH] app/testpmd: fix crash when using set fwd tx_first with NUMA

2014-04-30 Thread Thomas Monjalon
> From: Adrien Mazarguil > > When NUMA is enabled, the per-core fwd_lcore structure mbuf pool pointer > is not set, causing a crash. > > Initialize fwd_lcore after allocating NUMA memory pools. > > Signed-off-by: Adrien Mazarguil Acked-by: Thomas Monjalon Applied for version 1.6.0r2. Thank

[dpdk-dev] [PATCH] app/testpmd: fix crash when using set fwd tx_first with NUMA

2014-04-30 Thread David Marchand
From: Adrien Mazarguil When NUMA is enabled, the per-core fwd_lcore structure mbuf pool pointer is not set, causing a crash. Initialize fwd_lcore after allocating NUMA memory pools. Signed-off-by: Adrien Mazarguil --- app/test-pmd/testpmd.c | 20 +++- 1 file changed, 11 inse