Re: [dpdk-dev] [PATCH] app/testpmd: fix MTU after device configure

2020-11-16 Thread Thomas Monjalon
16/11/2020 19:50, Ferruh Yigit: > On 11/13/2020 11:44 AM, Ferruh Yigit wrote: > > In 'rte_eth_dev_configure()', if 'DEV_RX_OFFLOAD_JUMBO_FRAME' is not set > > the max frame size is limited to 'RTE_ETHER_MAX_LEN' (1518). > > This is mistake because for the PMDs that has frame size bigger than > > "R

Re: [dpdk-dev] [PATCH] app/testpmd: fix MTU after device configure

2020-11-16 Thread Ferruh Yigit
On 11/13/2020 11:44 AM, Ferruh Yigit wrote: In 'rte_eth_dev_configure()', if 'DEV_RX_OFFLOAD_JUMBO_FRAME' is not set the max frame size is limited to 'RTE_ETHER_MAX_LEN' (1518). This is mistake because for the PMDs that has frame size bigger than "RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN" (18 bytes)

Re: [dpdk-dev] [PATCH] app/testpmd: fix MTU after device configure

2020-11-13 Thread Ferruh Yigit
On 11/13/2020 2:53 PM, Andrew Rybchenko wrote: On 11/13/20 2:44 PM, Ferruh Yigit wrote: In 'rte_eth_dev_configure()', if 'DEV_RX_OFFLOAD_JUMBO_FRAME' is not set the max frame size is limited to 'RTE_ETHER_MAX_LEN' (1518). This is mistake because for the PMDs that has frame size bigger than "RTE_

Re: [dpdk-dev] [PATCH] app/testpmd: fix MTU after device configure

2020-11-13 Thread Andrew Rybchenko
On 11/13/20 2:44 PM, Ferruh Yigit wrote: > In 'rte_eth_dev_configure()', if 'DEV_RX_OFFLOAD_JUMBO_FRAME' is not set > the max frame size is limited to 'RTE_ETHER_MAX_LEN' (1518). > This is mistake because for the PMDs that has frame size bigger than > "RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN" (18 byt

[dpdk-dev] [PATCH] app/testpmd: fix MTU after device configure

2020-11-13 Thread Ferruh Yigit
In 'rte_eth_dev_configure()', if 'DEV_RX_OFFLOAD_JUMBO_FRAME' is not set the max frame size is limited to 'RTE_ETHER_MAX_LEN' (1518). This is mistake because for the PMDs that has frame size bigger than "RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN" (18 bytes), the MTU becomes less than 1500, causing a va