Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command

2017-12-03 Thread Raslan Darawsheh
@dpdk.org; Saleh Alsouqi Subject: Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command On 9/7/2017 1:17 AM, Wu, Jingjing wrote: >>> >>> Since dealing with device is kind of new, it can be OK to create new >>> command tree, but there are alread

Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command

2017-11-28 Thread Ferruh Yigit
On 9/7/2017 1:17 AM, Wu, Jingjing wrote: >>> >>> Since dealing with device is kind of new, it can be OK to create new >>> command tree, but there are already hotplug commands per port: >>> "port attach #PCI|#VDEV_NAME" >>> "port detach #P" >>> >> >> Those two commands deal with the etherdev hotplug

Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command

2017-09-07 Thread Wu, Jingjing
> > > > Since dealing with device is kind of new, it can be OK to create new > > command tree, but there are already hotplug commands per port: > > "port attach #PCI|#VDEV_NAME" > > "port detach #P" > > > > Those two commands deal with the etherdev hotplug API. > The new command should test the rt

Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command

2017-08-28 Thread Gaëtan Rivet
On Mon, Aug 28, 2017 at 11:30:47AM +0100, Ferruh Yigit wrote: > On 8/28/2017 10:55 AM, Gaëtan Rivet wrote: > > Hi Raslan, > > > > Redoing the review with the remarks from Thomas in mind. > > > > On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote: > >> Added hotplug in testpmd, to be

Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command

2017-08-28 Thread Thomas Monjalon
28/08/2017 12:30, Ferruh Yigit: > On 8/28/2017 10:55 AM, Gaëtan Rivet wrote: > > Hi Raslan, > > > > Redoing the review with the remarks from Thomas in mind. > > > > On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote: > >> Added hotplug in testpmd, to be able to test hotplug function

Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command

2017-08-28 Thread Ferruh Yigit
On 8/28/2017 10:55 AM, Gaëtan Rivet wrote: > Hi Raslan, > > Redoing the review with the remarks from Thomas in mind. > > On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote: >> Added hotplug in testpmd, to be able to test hotplug function >> in the PMD's. >> >> Signed-off-by: Raslan

Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command

2017-08-28 Thread Gaëtan Rivet
Hi Raslan, Redoing the review with the remarks from Thomas in mind. On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote: > Added hotplug in testpmd, to be able to test hotplug function > in the PMD's. > > Signed-off-by: Raslan Darawsheh > --- > app/test-pmd/cmdline.c | 44

Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command

2017-08-25 Thread Thomas Monjalon
25/08/2017 09:53, Gaëtan Rivet: > On Wed, Aug 23, 2017 at 06:18:34PM +0200, Thomas Monjalon wrote: > > 23/08/2017 17:09, Gaëtan Rivet: > > > Hello Raslan, > > > > > > On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote: > > > > Added hotplug in testpmd, to be able to test hotplug func

Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command

2017-08-25 Thread Gaëtan Rivet
On Wed, Aug 23, 2017 at 06:18:34PM +0200, Thomas Monjalon wrote: > 23/08/2017 17:09, Gaëtan Rivet: > > Hello Raslan, > > > > On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote: > > > Added hotplug in testpmd, to be able to test hotplug function > > > in the PMD's. > > > > > > Signed

Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command

2017-08-23 Thread Thomas Monjalon
23/08/2017 17:09, Gaëtan Rivet: > Hello Raslan, > > On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote: > > Added hotplug in testpmd, to be able to test hotplug function > > in the PMD's. > > > > Signed-off-by: Raslan Darawsheh [...] > > --- a/app/test-pmd/cmdline.c > > +++ b/app/t

Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command

2017-08-23 Thread Gaëtan Rivet
Hello Raslan, On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote: > Added hotplug in testpmd, to be able to test hotplug function > in the PMD's. > > Signed-off-by: Raslan Darawsheh > --- > app/test-pmd/cmdline.c | 44 > app/test-pmd/te

[dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command

2017-08-23 Thread Raslan Darawsheh
Added hotplug in testpmd, to be able to test hotplug function in the PMD's. Signed-off-by: Raslan Darawsheh --- app/test-pmd/cmdline.c | 44 app/test-pmd/testpmd.c | 18 ++ app/test-pmd/testpmd.h | 1 + 3 files changed, 63 insertions(