Re: [dpdk-dev] [PATCH] app/testpmd: add sanity checks when retrieving xstats

2018-06-12 Thread Remy Horton
Was out of office, so only saw the patchset this morning. Missing fixlines (watch out for subject line wrap): Fixes: e2aae1c1ced9 ("ethdev: remove name from extended statistic fetch") Fixes: 0a5beecf466a ("ethdev: revert xstats by ID") Otherwise looks good to me. A case of implementation simpli

Re: [dpdk-dev] [PATCH] app/testpmd: add sanity checks when retrieving xstats

2018-06-12 Thread David Marchand
Hey guys, On Thu, Jun 7, 2018 at 10:15 AM, David Marchand wrote: > Testpmd should not expect the xstats names and values arrays to be > aligned: neither the arrays sizes, nor the order in which the values are. > > This hid some bugs where pmds would either return wrong values count or > invalid s

[dpdk-dev] [PATCH] app/testpmd: add sanity checks when retrieving xstats

2018-06-07 Thread David Marchand
Testpmd should not expect the xstats names and values arrays to be aligned: neither the arrays sizes, nor the order in which the values are. This hid some bugs where pmds would either return wrong values count or invalid statistics indexes. Link: http://dpdk.org/browse/dpdk/commit/?id=5fd4d04969