Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines

2019-09-30 Thread Yigit, Ferruh
On 7/1/2019 9:15 AM, Bruce Richardson wrote: > On Mon, Jul 01, 2019 at 04:57:30AM +, Slava Ovsiienko wrote: >> I think we should compromise: keep existing RTE_TEST_PMD_RECORD_CORE_CYCLES >> and extend with runtime switch under this build-time option: >> >> #ifdef RTE_TEST_PMD_RECORD_CORE_CYCLES

Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines

2019-07-01 Thread Bruce Richardson
On Mon, Jul 01, 2019 at 04:57:30AM +, Slava Ovsiienko wrote: > I think we should compromise: keep existing RTE_TEST_PMD_RECORD_CORE_CYCLES > and extend with runtime switch under this build-time option: > > #ifdef RTE_TEST_PMD_RECORD_CORE_CYCLES > if (record_tx) > .. gather tx related stats..

Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines

2019-06-30 Thread Slava Ovsiienko
. WBR, Slava > -Original Message- > From: Bruce Richardson > Sent: Friday, June 28, 2019 17:20 > To: Iremonger, Bernard > Cc: Slava Ovsiienko ; dev@dpdk.org; Yigit, > Ferruh > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst > routines >

Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines

2019-06-28 Thread Bruce Richardson
Cc: dev@dpdk.org; Iremonger, Bernard ; > > Yigit, Ferruh > > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst > > routines > > > > OK, what do you think about this: > > > > #ifdef RTE_TEST_PMD_RECORD_CORE_CYCLES > > if (record_

Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines

2019-06-28 Thread Iremonger, Bernard
: Wednesday, June 26, 2019 16:21 > > To: Slava Ovsiienko > > Cc: dev@dpdk.org; bernard.iremon...@intel.com; ferruh.yi...@intel.com > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx > > burst routines > > > > On Wed, Jun 26, 2019 at 01:19:24PM +0

Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines

2019-06-26 Thread Slava Ovsiienko
ject: Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst > routines > > On Wed, Jun 26, 2019 at 01:19:24PM +, Slava Ovsiienko wrote: > > Hi, Bruce > > > > Do you mean using "if (core_rx_cycle_enabled) {...}" instead of #ifdef ? > > > &g

Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines

2019-06-26 Thread Bruce Richardson
On Wed, Jun 26, 2019 at 01:19:24PM +, Slava Ovsiienko wrote: > Hi, Bruce > > Do you mean using "if (core_rx_cycle_enabled) {...}" instead of #ifdef ? > > No, I did not try runtime control settings. > Instead I compared performance with all RECORD_CORE_XX_CYCLES options > enabled/disabled bui

Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines

2019-06-26 Thread Slava Ovsiienko
bject: Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst > routines > > On Wed, Jun 26, 2019 at 12:48:37PM +, Viacheslav Ovsiienko wrote: > > There is the testpmd configuration option called > > RTE_TEST_PMD_RECORD_CORE_CYCLES, if this one is turned on the

Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines

2019-06-26 Thread Bruce Richardson
On Wed, Jun 26, 2019 at 12:48:37PM +, Viacheslav Ovsiienko wrote: > There is the testpmd configuration option called > RTE_TEST_PMD_RECORD_CORE_CYCLES, if this one is turned on > the testpmd application measures the CPU clocks spent > within forwarding loop. This time is the sum of execution >

[dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines

2019-06-26 Thread Viacheslav Ovsiienko
There is the testpmd configuration option called RTE_TEST_PMD_RECORD_CORE_CYCLES, if this one is turned on the testpmd application measures the CPU clocks spent within forwarding loop. This time is the sum of execution times of rte_eth_rx_burst(), rte_eth_tx_burst(), rte_delay_us(), rte_pktmbuf_fr