Re: [dpdk-dev] [PATCH] app/procinfo: add device registers dump

2021-07-19 Thread Chengchang Tang
On 2021/7/18 1:53, Stephen Hemminger wrote: > On Sun, 25 Apr 2021 21:02:22 +0800 > "Min Hu (Connor)" wrote: > >> snprintf(file_name, MAX_FILE_NAME_SZ, "%s-port%u", >> +file_prefix, i); >> +fp_regs = fopen(file_name, "wb"); >> +if

Re: [dpdk-dev] [PATCH] app/procinfo: add device registers dump

2021-07-18 Thread Chengchang Tang
On 2021/7/18 1:51, Stephen Hemminger wrote: > On Sun, 25 Apr 2021 21:02:22 +0800 > "Min Hu (Connor)" wrote: > >> + >> +memset(®_info, 0, sizeof(reg_info)); >> +memset(&dev_info, 0, sizeof(dev_info)); > > This memset is redundant, rte_eth_dev_info_get already has the sam

Re: [dpdk-dev] [PATCH] app/procinfo: add device registers dump

2021-07-17 Thread Stephen Hemminger
On Sun, 25 Apr 2021 21:02:22 +0800 "Min Hu (Connor)" wrote: > snprintf(file_name, MAX_FILE_NAME_SZ, "%s-port%u", > + file_prefix, i); > + fp_regs = fopen(file_name, "wb"); > + if (fp_regs == NULL) { > + printf("

Re: [dpdk-dev] [PATCH] app/procinfo: add device registers dump

2021-07-17 Thread Stephen Hemminger
On Sun, 25 Apr 2021 21:02:22 +0800 "Min Hu (Connor)" wrote: > + > + memset(®_info, 0, sizeof(reg_info)); > + memset(&dev_info, 0, sizeof(dev_info)); This memset is redundant, rte_eth_dev_info_get already has the same memset. For the registers, ethdev should be fixed to do

Re: [dpdk-dev] [PATCH] app/procinfo: add device registers dump

2021-06-10 Thread Pattan, Reshma
> -Original Message- > From: Chengchang Tang > >> + ret = rte_eth_dev_get_reg_info(i, ®_info); > >> + if (ret) { > >> + printf("Error getting device reg info: %d\n", ret); > >> + continue; > >> + } > >> + > >> + buf_

Re: [dpdk-dev] [PATCH] app/procinfo: add device registers dump

2021-06-04 Thread Chengchang Tang
On 2021/6/4 23:04, Pattan, Reshma wrote: > > >> -Original Message- >> From: Min Hu (Connor) > > > >> +ret = rte_eth_dev_get_reg_info(i, ®_info); >> +if (ret) { >> +printf("Error getting device reg info: %d\n", ret); >> +

Re: [dpdk-dev] [PATCH] app/procinfo: add device registers dump

2021-06-04 Thread Pattan, Reshma
> -Original Message- > From: Min Hu (Connor) > + ret = rte_eth_dev_get_reg_info(i, ®_info); > + if (ret) { > + printf("Error getting device reg info: %d\n", ret); > + continue; > + } > + > + buf_

Re: [dpdk-dev] [PATCH] app/procinfo: add device registers dump

2021-05-19 Thread Thomas Monjalon
Ping for review. It looks too late for 21.05, moved as Deferred in patchwork. 25/04/2021 15:02, Min Hu (Connor): > From: Chengchang Tang > > This patch add support for dump the device registers from a running > application. It can help developers locate the problem. > > Signed-off-by: Chengcha

[dpdk-dev] [PATCH] app/procinfo: add device registers dump

2021-04-25 Thread Min Hu (Connor)
From: Chengchang Tang This patch add support for dump the device registers from a running application. It can help developers locate the problem. Signed-off-by: Chengchang Tang Signed-off-by: Min Hu (Connor) --- app/proc-info/main.c | 92 +++- 1