Re: [dpdk-dev] [PATCH] app/pdump: exits once primary app exited

2019-04-26 Thread Burakov, Anatoly
On 26-Apr-19 3:49 PM, Suanming.Mou wrote: On 2019/4/26 22:39, Burakov, Anatoly wrote: On 26-Apr-19 3:32 PM, Suanming.Mou wrote: On 2019/4/26 21:46, Burakov, Anatoly wrote: On 26-Apr-19 1:08 PM, Suanming.Mou wrote: On 2019/4/26 18:56, Varghese, Vipin wrote: I will leave this suggestion op

Re: [dpdk-dev] [PATCH] app/pdump: exits once primary app exited

2019-04-26 Thread Suanming . Mou
On 2019/4/26 22:39, Burakov, Anatoly wrote: On 26-Apr-19 3:32 PM, Suanming.Mou wrote: On 2019/4/26 21:46, Burakov, Anatoly wrote: On 26-Apr-19 1:08 PM, Suanming.Mou wrote: On 2019/4/26 18:56, Varghese, Vipin wrote: I will leave this suggestion open for comments from the maintainer. Hi,

Re: [dpdk-dev] [PATCH] app/pdump: exits once primary app exited

2019-04-26 Thread Burakov, Anatoly
On 26-Apr-19 3:32 PM, Suanming.Mou wrote: On 2019/4/26 21:46, Burakov, Anatoly wrote: On 26-Apr-19 1:08 PM, Suanming.Mou wrote: On 2019/4/26 18:56, Varghese, Vipin wrote: I will leave this suggestion open for comments from the maintainer. Hi, Thanks for your suggestion. I have also tried

Re: [dpdk-dev] [PATCH] app/pdump: exits once primary app exited

2019-04-26 Thread Suanming . Mou
On 2019/4/26 21:46, Burakov, Anatoly wrote: On 26-Apr-19 1:08 PM, Suanming.Mou wrote: On 2019/4/26 18:56, Varghese, Vipin wrote: I will leave this suggestion open for comments from the maintainer. Hi, Thanks for your suggestion. I have also tried to add an slave core to monitor the prim

Re: [dpdk-dev] [PATCH] app/pdump: exits once primary app exited

2019-04-26 Thread Burakov, Anatoly
On 26-Apr-19 1:08 PM, Suanming.Mou wrote: On 2019/4/26 18:56, Varghese, Vipin wrote: I will leave this suggestion open for comments from the maintainer. Hi, Thanks for your suggestion. I have also tried to add an slave core to monitor the primary status this afternoon.  It works. I doubt

Re: [dpdk-dev] [PATCH] app/pdump: exits once primary app exited

2019-04-26 Thread Suanming . Mou
On 2019/4/26 18:56, Varghese, Vipin wrote: I will leave this suggestion open for comments from the maintainer. Hi, Thanks for your suggestion. I have also tried to add an slave core to monitor the primary status this afternoon.  It works. I doubt if it can be add an new option as you sug

Re: [dpdk-dev] [PATCH] app/pdump: exits once primary app exited

2019-04-26 Thread Varghese, Vipin
I will leave this suggestion open for comments from the maintainer. snipped Hi, Looks like something in email format setting is affecting the style. Please find my replies below snipped As per the current suggested code flow check is added to while loop in function `dump_packets'. Thanks f

Re: [dpdk-dev] [PATCH] app/pdump: exits once primary app exited

2019-04-26 Thread Varghese, Vipin
Hi, Looks like something in email format setting is affecting the style. Please find my replies below snipped As per the current suggested code flow check is added to while loop in function `dump_packets'. Thanks for the reply. Since want to make it clean, the code was here. However, it see

Re: [dpdk-dev] [PATCH] app/pdump: exits once primary app exited

2019-04-26 Thread Suanming . Mou
On 2019/4/25 23:51, Varghese, Vipin wrote: Hi, snipped @@ -847,6 +847,10 @@ struct parse_val { pdump_rxtx(pt->rx_ring, pt->rx_vdev_id, &pt->stats); if (pt->dir & RTE_PDUMP_FLAG_TX) pdump_rxtx(pt->tx_ring, pt->tx_vdev_id, &pt->stats); + + /* Once p

Re: [dpdk-dev] [PATCH] app/pdump: exits once primary app exited

2019-04-25 Thread Varghese, Vipin
Hi, snipped > @@ -847,6 +847,10 @@ struct parse_val { > pdump_rxtx(pt->rx_ring, pt->rx_vdev_id, &pt->stats); > if (pt->dir & RTE_PDUMP_FLAG_TX) > pdump_rxtx(pt->tx_ring, pt->tx_vdev_id, &pt->stats); > + > + /* Once primary exits, so will I. */ > + if (!rte

[dpdk-dev] [PATCH] app/pdump: exits once primary app exited

2019-04-25 Thread Suanming . Mou
If primary app exited, meaningless for pdump keeps running anymore. Signed-off-by: Suanming.Mou --- app/pdump/main.c | 4 1 file changed, 4 insertions(+) diff --git a/app/pdump/main.c b/app/pdump/main.c index 3d208548fa13..f1ff2a3ceb4f 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @