[dpdk-dev] [PATCH] add free hugepage function

2014-10-30 Thread Matthew Hall
Yes. I once had to write a cron job in Perl that monitored for unused regions and deleted them before the SHM subsystem ran out of memory. Possible, yes, but irritating. -- Sent from my mobile device. On October 30, 2014 3:18:56 AM PDT, Neil Horman wrote: >On Wed, Oct 29, 2014 at 08:23:25PM -

[dpdk-dev] [PATCH] add free hugepage function

2014-10-30 Thread Neil Horman
On Wed, Oct 29, 2014 at 08:23:25PM -0700, Matthew Hall wrote: > On Wed, Oct 29, 2014 at 11:32:12AM -0400, Neil Horman wrote: > > > > > Well, abnormal termination results in abnormal consequences. You expect > > garbage to get left behind of a program crashes, so I wouldn't really worry > > about

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Matthew Hall
On Wed, Oct 29, 2014 at 11:32:12AM -0400, Neil Horman wrote: > > > Well, abnormal termination results in abnormal consequences. You expect > garbage to get left behind of a program crashes, so I wouldn't really worry > about that too much. If you really wanted to you can register chained > hand

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Bruce Richardson
up. /Bruce > > > regards > > Kannan Babu > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman > > Sent: Wednesday, October 29, 2014 7:58 PM > > To: Richardson, Bruce > > Cc: dev at dpdk.org > >

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Ramia, Kannan Babu
-boun...@dpdk.org] On Behalf Of Neil Horman Sent: Wednesday, October 29, 2014 7:58 PM To: Richardson, Bruce Cc: dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH] add free hugepage function On Wed, Oct 29, 2014 at 10:26:35AM +, Bruce Richardson wrote: > On Wed, Oct 29, 2014 at 02:49:05PM +0

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Linhaifeng
On 2014/10/29 13:26, Qiu, Michael wrote: > ? 10/29/2014 11:46 AM, Matthew Hall ??: >> On Wed, Oct 29, 2014 at 03:27:58AM +, Qiu, Michael wrote: >>> I just saw one return path with value '0', and no any other place >>> return a negative value, so it is better to be designed as one >>> non-r

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Linhaifeng
On 2014/10/29 11:44, Matthew Hall wrote: > On Wed, Oct 29, 2014 at 03:27:58AM +, Qiu, Michael wrote: >> I just saw one return path with value '0', and no any other place >> return a negative value, so it is better to be designed as one >> non-return function, >> >> +void >> +rte_eal_hugepa

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Neil Horman
inal Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman > Sent: Wednesday, October 29, 2014 7:58 PM > To: Richardson, Bruce > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] add free hugepage function > > On Wed, Oct 29, 2014 at 10:26:35AM +, B

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread linhaifeng
maybe somebody want to free hugepages when application exit. so add this function for application to release hugepages when exit. Signed-off-by: linhaifeng --- .../lib/librte_eal/common/include/rte_memory.h | 11 + .../lib/librte_eal/linuxapp/eal/eal_memory.c | 27 +

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Neil Horman
On Wed, Oct 29, 2014 at 10:26:35AM +, Bruce Richardson wrote: > On Wed, Oct 29, 2014 at 02:49:05PM +0800, Linhaifeng wrote: > > > > > > On 2014/10/29 13:26, Qiu, Michael wrote: > > > ? 10/29/2014 11:46 AM, Matthew Hall ??: > > >> On Wed, Oct 29, 2014 at 03:27:58AM +, Qiu, Michael wrote: >

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Bruce Richardson
On Wed, Oct 29, 2014 at 02:49:05PM +0800, Linhaifeng wrote: > > > On 2014/10/29 13:26, Qiu, Michael wrote: > > ? 10/29/2014 11:46 AM, Matthew Hall ??: > >> On Wed, Oct 29, 2014 at 03:27:58AM +, Qiu, Michael wrote: > >>> I just saw one return path with value '0', and no any other place > >>>

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Qiu, Michael
? 10/29/2014 11:46 AM, Matthew Hall ??: > On Wed, Oct 29, 2014 at 03:27:58AM +, Qiu, Michael wrote: >> I just saw one return path with value '0', and no any other place >> return a negative value, so it is better to be designed as one >> non-return function, >> >> +void >> +rte_eal_hugepage_

[dpdk-dev] [PATCH] add free hugepage function

2014-10-29 Thread Qiu, Michael
10/29/2014 10:55 AM, linhaifeng : > maybe somebody want to free hugepages when application exit. > so add this function for application to release hugepages when exit. > > Signed-off-by: linhaifeng > --- > .../lib/librte_eal/common/include/rte_memory.h | 11 + > .../lib/librte_eal/li

[dpdk-dev] [PATCH] add free hugepage function

2014-10-28 Thread Matthew Hall
On Wed, Oct 29, 2014 at 03:27:58AM +, Qiu, Michael wrote: > I just saw one return path with value '0', and no any other place > return a negative value, so it is better to be designed as one > non-return function, > > +void > +rte_eal_hugepage_free(void) > +{ > + struct hugepage_file *h