Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-17 Thread David Marchand
On Fri, Jan 17, 2020 at 8:02 PM Neil Horman wrote: > HmmmI wonder if its worth orchestrating the build system to use a git > submodule storing whatever our CI system can produce and using it as a cache, > and falling back to a local build if the appropriate arch isn't found? That > might offe

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-17 Thread Neil Horman
On Thu, Jan 16, 2020 at 09:01:52PM +0100, Thomas Monjalon wrote: > 16/01/2020 19:49, Neil Horman: > > On Thu, Jan 16, 2020 at 03:20:48PM +0100, Thomas Monjalon wrote: > > > 16/01/2020 12:52, Neil Horman: > > > > On Wed, Jan 15, 2020 at 01:38:17PM +0100, Thomas Monjalon wrote: > > > > > 15/01/2020 1

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-16 Thread Thomas Monjalon
16/01/2020 19:49, Neil Horman: > On Thu, Jan 16, 2020 at 03:20:48PM +0100, Thomas Monjalon wrote: > > 16/01/2020 12:52, Neil Horman: > > > On Wed, Jan 15, 2020 at 01:38:17PM +0100, Thomas Monjalon wrote: > > > > 15/01/2020 12:33, Neil Horman: > > > > > On Wed, Jan 15, 2020 at 12:19:30AM +0100, Thom

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-16 Thread Neil Horman
On Thu, Jan 16, 2020 at 03:20:48PM +0100, Thomas Monjalon wrote: > 16/01/2020 12:52, Neil Horman: > > On Wed, Jan 15, 2020 at 01:38:17PM +0100, Thomas Monjalon wrote: > > > 15/01/2020 12:33, Neil Horman: > > > > On Wed, Jan 15, 2020 at 12:19:30AM +0100, Thomas Monjalon wrote: > > > > > 20/12/2019 1

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-16 Thread Thomas Monjalon
16/01/2020 12:52, Neil Horman: > On Wed, Jan 15, 2020 at 01:38:17PM +0100, Thomas Monjalon wrote: > > 15/01/2020 12:33, Neil Horman: > > > On Wed, Jan 15, 2020 at 12:19:30AM +0100, Thomas Monjalon wrote: > > > > 20/12/2019 17:20, Kinsella, Ray: > > > > > From: Richardson, Bruce > > > > > > From: D

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-16 Thread Neil Horman
On Wed, Jan 15, 2020 at 01:38:17PM +0100, Thomas Monjalon wrote: > 15/01/2020 12:33, Neil Horman: > > On Wed, Jan 15, 2020 at 12:19:30AM +0100, Thomas Monjalon wrote: > > > 20/12/2019 17:20, Kinsella, Ray: > > > > From: Richardson, Bruce > > > > > From: David Marchand > > > > > > +Checking ABI co

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-15 Thread Burakov, Anatoly
On 06-Jan-20 1:17 PM, Aaron Conole wrote: Thomas Monjalon writes: 20/12/2019 17:20, Kinsella, Ray: -Original Message- From: Richardson, Bruce Sent: Friday 20 December 2019 15:32 To: David Marchand ; dev@dpdk.org Cc: tho...@monjalon.net; Laatz, Kevin ; acon...@redhat.com; nhor...@tuxd

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-15 Thread Thomas Monjalon
15/01/2020 12:33, Neil Horman: > On Wed, Jan 15, 2020 at 12:19:30AM +0100, Thomas Monjalon wrote: > > 20/12/2019 17:20, Kinsella, Ray: > > > From: Richardson, Bruce > > > > From: David Marchand > > > > > +Checking ABI compatibility > > > > > +-- > > > > > + > > > > > +The

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-15 Thread Neil Horman
On Wed, Jan 15, 2020 at 12:19:30AM +0100, Thomas Monjalon wrote: > 20/12/2019 17:20, Kinsella, Ray: > > From: Richardson, Bruce > > > From: David Marchand > > > > +Checking ABI compatibility > > > > +-- > > > > + > > > > +The first thing is to build reference binaries for

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-14 Thread Thomas Monjalon
20/12/2019 17:20, Kinsella, Ray: > From: Richardson, Bruce > > From: David Marchand > > > +Checking ABI compatibility > > > +-- > > > + > > > +The first thing is to build reference binaries for the latest > > release > > > +your patches are built on top of. > > > + > > > +

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-06 Thread Aaron Conole
Thomas Monjalon writes: > 20/12/2019 17:20, Kinsella, Ray: >> > -Original Message- >> > From: Richardson, Bruce >> > Sent: Friday 20 December 2019 15:32 >> > To: David Marchand ; dev@dpdk.org >> > Cc: tho...@monjalon.net; Laatz, Kevin ; >> > acon...@redhat.com; nhor...@tuxdriver.com; Mic

Re: [dpdk-dev] [PATCH] add ABI checks

2020-01-03 Thread Kinsella, Ray
> -Original Message- > From: Richardson, Bruce > Sent: Friday 20 December 2019 15:32 > To: David Marchand ; dev@dpdk.org > Cc: tho...@monjalon.net; Laatz, Kevin ; > acon...@redhat.com; nhor...@tuxdriver.com; Michael Santana > ; Mcnamara, John ; > Kovacevic, Marko ; Kinsella, Ray > > Subje

Re: [dpdk-dev] [PATCH] add ABI checks

2019-12-20 Thread Thomas Monjalon
20/12/2019 17:20, Kinsella, Ray: > > -Original Message- > > From: Richardson, Bruce > > Sent: Friday 20 December 2019 15:32 > > To: David Marchand ; dev@dpdk.org > > Cc: tho...@monjalon.net; Laatz, Kevin ; > > acon...@redhat.com; nhor...@tuxdriver.com; Michael Santana > > ; Mcnamara, John

Re: [dpdk-dev] [PATCH] add ABI checks

2019-12-20 Thread Neil Horman
On Fri, Dec 20, 2019 at 04:20:58PM +0100, David Marchand wrote: > Starting from Kevin and Bruce idea of using libabigail, here is an > alternate approach to implement ABI checks. > > By default, those checks are disabled and enabling them requires a > manual step that generates the ABI dumps on a

Re: [dpdk-dev] [PATCH] add ABI checks

2019-12-20 Thread Richardson, Bruce
> -Original Message- > From: David Marchand > Sent: Friday, December 20, 2019 3:21 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Richardson, Bruce ; > Laatz, Kevin ; acon...@redhat.com; > nhor...@tuxdriver.com; Michael Santana ; > Mcnamara, John ; Kovacevic, Marko > > Subject: [PATC

[dpdk-dev] [PATCH] add ABI checks

2019-12-20 Thread David Marchand
Starting from Kevin and Bruce idea of using libabigail, here is an alternate approach to implement ABI checks. By default, those checks are disabled and enabling them requires a manual step that generates the ABI dumps on a reference version for a set of configurations. Those checks are enabled i