Re: [dpdk-dev] [PATCH] acl: Fix RTE_ACL_RULE_SZ macro definition

2020-07-08 Thread Levend Sayar
Sure. I am really sorry for not being verbose enough. >From lib/librte_acl/rte_acl.h #define RTE_ACL_RULE_DEF(name, fld_num) struct name {\ struct rte_acl_rule_data data; \ struct rte_acl_field field[fld_num]; \ } RTE_ACL_RULE_DEF(rte_acl_rule,); When you put the d

Re: [dpdk-dev] [PATCH] acl: Fix RTE_ACL_RULE_SZ macro definition

2020-07-08 Thread Levend Sayar
Yes you are totally right. I overlooked the alignment of struct components. Sorry for that. But imho, not to have such confusions, Another define can be added such as #define RTE_ACL_RULE_SIZE(xz) sizeof(struct xz) Thanks for your time. Best, Levend On Tue, Jul 7, 2020 at 7:45 PM Ananyev,

Re: [dpdk-dev] [PATCH] acl: Fix RTE_ACL_RULE_SZ macro definition

2020-07-07 Thread Ananyev, Konstantin
From: Levend Sayar Sent: Tuesday, July 7, 2020 4:25 PM To: Ananyev, Konstantin Cc: dev@dpdk.org Subject: Re: [PATCH] acl: Fix RTE_ACL_RULE_SZ macro definition Sure. I am really sorry for not being verbose enough. From lib/librte_acl/rte_acl.h #define RTE_ACL_RULE_DEF(name, fld_num) struct na

[dpdk-dev] [PATCH] acl: Fix RTE_ACL_RULE_SZ macro definition

2020-07-07 Thread levendsayar
From: Levend Sayar Signed-off-by: Levend Sayar --- lib/librte_acl/rte_acl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_acl/rte_acl.h b/lib/librte_acl/rte_acl.h index aa22e70c6..d34fdbc0e 100644 --- a/lib/librte_acl/rte_acl.h +++ b/lib/librte_acl/rte_acl.h @@

Re: [dpdk-dev] [PATCH] acl: Fix RTE_ACL_RULE_SZ macro definition

2020-07-07 Thread Ananyev, Konstantin
> From: Levend Sayar Could you provide some explanation: What do you think is wrong with current version and why, and what your fix does. > > Signed-off-by: Levend Sayar > --- > lib/librte_acl/rte_acl.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_ac