[dpdk-dev] [PATCH] Fix librte_pmd_pcap driver double stop error

2014-10-06 Thread Neil Horman
On Sat, Oct 04, 2014 at 07:14:21PM +0100, Nicol?s Pernas Maradei wrote: > Hi, > > You are correct, the parameters received in the driver are allocated in > devargs_list (char *params variable). However, they already get strdup'd in > rte_kvargs_parse(). This newly allocated string is part of kvlis

[dpdk-dev] [PATCH] Fix librte_pmd_pcap driver double stop error

2014-10-04 Thread Nicolás Pernas Maradei
Hi, You are correct, the parameters received in the driver are allocated in devargs_list (char *params variable). However, they already get strdup'd in rte_kvargs_parse(). This newly allocated string is part of kvlist and never freed up. The params variable is never used again so it can be fre

[dpdk-dev] [PATCH] Fix librte_pmd_pcap driver double stop error

2014-09-29 Thread Thomas Monjalon
2014-09-10 17:17, Nicol?s Pernas Maradei: > From: Nicola?s Pernas Maradei > > librte_pmd_pcap driver was opening the pcap/interfaces only at init time and > closing them only when the port was being stopped. This behaviour would cause > problems (leading to segfault) if the user closed the port 2

[dpdk-dev] [PATCH] Fix librte_pmd_pcap driver double stop error

2014-09-29 Thread Neil Horman
On Wed, Sep 10, 2014 at 05:17:05PM -0300, Nicol?s Pernas Maradei wrote: > From: Nicola?s Pernas Maradei > > librte_pmd_pcap driver was opening the pcap/interfaces only at init time and > closing them only when the port was being stopped. This behaviour would cause > problems (leading to segfault)

[dpdk-dev] [PATCH] Fix librte_pmd_pcap driver double stop error

2014-09-10 Thread Nicolás Pernas Maradei
From: Nicola?s Pernas Maradei librte_pmd_pcap driver was opening the pcap/interfaces only at init time and closing them only when the port was being stopped. This behaviour would cause problems (leading to segfault) if the user closed the port 2 times. The first time the pcap/interfaces would be