Re: [dpdk-dev] [PATCH] app/proc-info:fix port mask parse bug

2018-11-05 Thread Pattan, Reshma
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Li Han To avoid typecast below , please use uint64_t for enabled_port_mask. So change below function return type to uint64_t > -static int > +static uint32_t > parse_portmask(const char *portmask) > { Dec

Re: [dpdk-dev] [PATCH] app/proc-info:fix port mask parse bug

2018-11-05 Thread Thomas Monjalon
+Cc Reshma Please could you review this patch? 27/09/2018 09:01, Li Han: > parse_portmask return type is int,but global variable > "enabled_port_mask" type is uint32_t.so in proc_info_parse_args > function,when parse_portmask return -1,"enabled_port_mask" will > get a huge value and "if (enabled

[dpdk-dev] [PATCH] app/proc-info:fix port mask parse bug

2018-09-27 Thread Li Han
parse_portmask return type is int,but global variable "enabled_port_mask" type is uint32_t.so in proc_info_parse_args function,when parse_portmask return -1,"enabled_port_mask" will get a huge value and "if (enabled_port_mask == 0)" will never happen. Signed-off-by: Li Han --- app/proc-info/main