Re: [dpdk-dev] [EXT] Re: [PATCH] RFC: ethdev: add reassembly offload

2021-09-21 Thread Thomas Monjalon
29/08/2021 15:14, Akhil Goyal: > > On 8/23/21 1:02 PM, Akhil Goyal wrote: > > > +#define DEV_RX_OFFLOAD_REASSEMBLY0x1000 > > > > I think it should be: > > RTE_ETH_RX_OFFLOAD_IPV4_REASSEMBLY > > > > i.e. have correct prefix similar to > > RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT and mention IPv

Re: [dpdk-dev] [EXT] Re: [PATCH] RFC: ethdev: add reassembly offload

2021-09-13 Thread Anoob Joseph
Hi Andrew, Rosen, Please see inline. Thanks, Anoob > -Original Message- > From: Andrew Rybchenko > Sent: Monday, September 13, 2021 12:52 PM > To: Xu, Rosen ; Anoob Joseph > ; Yigit, Ferruh ; Andrew > Rybchenko > Cc: Nicolau, Radu ; Doherty, Declan > ; hemant.agra...@nxp.com; > ma...@n

Re: [dpdk-dev] [EXT] Re: [PATCH] RFC: ethdev: add reassembly offload

2021-09-13 Thread Andrew Rybchenko
On 9/13/21 9:56 AM, Xu, Rosen wrote: > Hi, > >> -Original Message- >> From: Anoob Joseph >> Sent: Wednesday, September 08, 2021 18:30 >> To: Yigit, Ferruh ; Xu, Rosen ; >> Andrew Rybchenko >> Cc: Nicolau, Radu ; Doherty, Declan >> ; hemant.agra...@nxp.com; >> ma...@nvidia.com; Ananyev, K

Re: [dpdk-dev] [EXT] Re: [PATCH] RFC: ethdev: add reassembly offload

2021-09-12 Thread Xu, Rosen
Hi, > -Original Message- > From: Anoob Joseph > Sent: Wednesday, September 08, 2021 18:30 > To: Yigit, Ferruh ; Xu, Rosen ; > Andrew Rybchenko > Cc: Nicolau, Radu ; Doherty, Declan > ; hemant.agra...@nxp.com; > ma...@nvidia.com; Ananyev, Konstantin ; > tho...@monjalon.net; Ankur Dwivedi

Re: [dpdk-dev] [EXT] Re: [PATCH] RFC: ethdev: add reassembly offload

2021-09-08 Thread Anoob Joseph
Hi Ferruh, Rosen, Andrew, Please see inline. Thanks, Anoob > Subject: [EXT] Re: [PATCH] RFC: ethdev: add reassembly offload > > External Email > > -- > On 8/23/2021 11:02 AM, Akhil Goyal wrote: > > Reassembly is a costly opera

Re: [dpdk-dev] [EXT] Re: [PATCH] RFC: ethdev: add reassembly offload

2021-08-29 Thread Akhil Goyal
> On 8/23/21 1:02 PM, Akhil Goyal wrote: > > Reassembly is a costly operation if it is done in > > software, however, if it is offloaded to HW, it can > > considerably save application cycles. > > The operation becomes even more costlier if IP fragmants > > are encrypted. > > > > To resolve above t