Re: [dpdk-dev] [1/4] net/virtio: fix the control vq support

2019-01-23 Thread Maxime Coquelin
On 1/23/19 5:33 PM, Ilya Maximets wrote: Hmm. Nevermind. Please, ignore my previous comments to this patch. Patch seems compliant to spec, but the spec is not very clear. Ok, thanks for the review and the folluw-up. Maxime Best regards, Ilya Maximets. On 23.01.2019 16:09, Ilya Maximets w

Re: [dpdk-dev] [1/4] net/virtio: fix the control vq support

2019-01-23 Thread Ilya Maximets
Hmm. Nevermind. Please, ignore my previous comments to this patch. Patch seems compliant to spec, but the spec is not very clear. Best regards, Ilya Maximets. On 23.01.2019 16:09, Ilya Maximets wrote: > On 22.01.2019 20:01, Tiwei Bie wrote: >> This patch mainly fixed below issues in the packed ri

Re: [dpdk-dev] [1/4] net/virtio: fix the control vq support

2019-01-23 Thread Ilya Maximets
On 22.01.2019 20:01, Tiwei Bie wrote: > This patch mainly fixed below issues in the packed ring based > control vq support in virtio driver: > > 1. When parsing the used descriptors, we have to track the >number of descs that we need to skip; > 2. vq->vq_free_cnt was decreased twice for a same