Re: [RFT] net/nfb: use dynamic logtype

2023-12-07 Thread Stephen Hemminger
On Thu, 07 Dec 2023 11:37:52 +0100 Martin Spinler wrote: > Also, the nfb_rx.h and nfb_tx.h files use the macro NFB_LOG inside, > please add '#include "nfb_log.h"' into them (then the include in > nfb_rx.c will be duplicate). Otherwise, all .c sources, which include > main nfb.h, don't compile. >

Re: [RFT] net/nfb: use dynamic logtype

2023-12-07 Thread Martin Spinler
Thanks for patch! There are some issues. On Wed, 2023-12-06 at 09:51 -0800, Stephen Hemminger wrote: > > diff --git a/drivers/net/nfb/nfb_log.h b/drivers/net/nfb/nfb_log.h > new file mode 100644 > index ..fac66a38d4b3 > --- /dev/null > +++ b/drivers/net/nfb/nfb_log.h > @@ -0,0 +1,13 @

[RFT] net/nfb: use dynamic logtype

2023-12-06 Thread Stephen Hemminger
All drivers should be using dynamic logtype. This should have been caught during initial driver review. Since this driver requires non-standard external library this patch can not be tested by me. Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver") Signed-off-by: Stephen Hemminger --- drive