Re: [RFC PATCH v2 3/9] vhost: annotate virtqueue access lock

On Thu, Apr 7, 2022 at 3:40 AM Hu, Jiayu wrote: > > diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h index > > a9edc271aa..158460b7d7 100644 > > --- a/lib/vhost/vhost.h > > +++ b/lib/vhost/vhost.h > > @@ -834,6 +834,7 @@ vhost_need_event(uint16_t event_idx, uint16_t > > new_idx, uint16_t old) >

RE: [RFC PATCH v2 3/9] vhost: annotate virtqueue access lock

Hi David, Please see replies inline. > -Original Message- > From: David Marchand > Sent: Wednesday, March 30, 2022 9:50 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Hu, > Jiayu ; Wang, YuanX ; Ding, > Xuan > Subject: [RFC PATCH v2 3/9] v

[RFC PATCH v2 3/9] vhost: annotate virtqueue access lock

This change simply annotates existing paths of the code leading to manipulations of the vq->access_lock. One small change is required: vhost_poll_enqueue_completed was getting a queue_id to get hold of the vq, while its callers already knew of the vq. For the annotation sake, vq is now directly pa