Re: [RFC PATCH] ethdev: advertise flow restore in mbuf

2023-06-15 Thread David Marchand
On Wed, Jun 14, 2023 at 6:46 PM Slava Ovsiienko wrote: > > Hi, David > > It looks like a good application datapath optimization, as for me. > But I see some concerns: > > 1. Are we sure the PMD should register the flag, not application? > IIRC, usually application registers needed flags/fields and

RE: [RFC PATCH] ethdev: advertise flow restore in mbuf

2023-06-14 Thread Slava Ovsiienko
L) ; > i.maxim...@ovn.org; Aman Singh ; Yuying > Zhang ; Matan Azrad ; Slava > Ovsiienko ; Andrew Rybchenko > ; Ferruh Yigit ; Ori > Kam > Subject: [RFC PATCH] ethdev: advertise flow restore in mbuf > > As reported by Ilya [1], unconditionally calling > rte_flow_get_restore_inf

Re: [RFC PATCH] ethdev: advertise flow restore in mbuf

2023-06-01 Thread David Marchand
On Thu, Jun 1, 2023 at 12:02 PM Ori Kam wrote: > > Hi David, > > > -Original Message- > > From: David Marchand > > Sent: Thursday, June 1, 2023 12:43 PM > > Subject: Re: [RFC PATCH] ethdev: advertise flow restore in mbuf > > > > O

RE: [RFC PATCH] ethdev: advertise flow restore in mbuf

2023-06-01 Thread Ori Kam
Hi David, > -Original Message- > From: David Marchand > Sent: Thursday, June 1, 2023 12:43 PM > Subject: Re: [RFC PATCH] ethdev: advertise flow restore in mbuf > > On Thu, Jun 1, 2023 at 11:31 AM Ori Kam wrote: > > > > > > > > > -Ori

Re: [RFC PATCH] ethdev: advertise flow restore in mbuf

2023-06-01 Thread David Marchand
On Thu, Jun 1, 2023 at 11:31 AM Ori Kam wrote: > > > > > -Original Message- > > From: David Marchand > > Sent: Thursday, June 1, 2023 11:48 AM > > > > On Wed, May 24, 2023 at 8:44 PM David Marchand > > wrote: > > > On Wed, May 24, 2023 at 6:00 PM Ori Kam wrote: > > > > > As reported by

RE: [RFC PATCH] ethdev: advertise flow restore in mbuf

2023-06-01 Thread Ori Kam
> -Original Message- > From: David Marchand > Sent: Thursday, June 1, 2023 11:48 AM > > On Wed, May 24, 2023 at 8:44 PM David Marchand > wrote: > > On Wed, May 24, 2023 at 6:00 PM Ori Kam wrote: > > > > As reported by Ilya [1], unconditionally calling > > > > rte_flow_get_restore_info

Re: [RFC PATCH] ethdev: advertise flow restore in mbuf

2023-06-01 Thread David Marchand
On Wed, May 24, 2023 at 8:44 PM David Marchand wrote: > On Wed, May 24, 2023 at 6:00 PM Ori Kam wrote: > > > As reported by Ilya [1], unconditionally calling > > > rte_flow_get_restore_info() impacts an application performance for drivers > > > that do not provide this ops. > > > It could also im

Re: [RFC PATCH] ethdev: advertise flow restore in mbuf

2023-05-24 Thread David Marchand
Hello Ori, On Wed, May 24, 2023 at 6:00 PM Ori Kam wrote: > > As reported by Ilya [1], unconditionally calling > > rte_flow_get_restore_info() impacts an application performance for drivers > > that do not provide this ops. > > It could also impact processing of packets that require no call to >

RE: [RFC PATCH] ethdev: advertise flow restore in mbuf

2023-05-24 Thread Ori Kam
Hi David > -Original Message- > From: David Marchand > Sent: Friday, May 5, 2023 1:31 PM > > As reported by Ilya [1], unconditionally calling > rte_flow_get_restore_info() impacts an application performance for drivers > that do not provide this ops. > It could also impact processing of

Re: [RFC PATCH] ethdev: advertise flow restore in mbuf

2023-05-24 Thread David Marchand
Hello guys, On Fri, May 5, 2023 at 12:31 PM David Marchand wrote: > > As reported by Ilya [1], unconditionally calling > rte_flow_get_restore_info() impacts an application performance for drivers > that do not provide this ops. > It could also impact processing of packets that require no call to

[RFC PATCH] ethdev: advertise flow restore in mbuf

2023-05-05 Thread David Marchand
As reported by Ilya [1], unconditionally calling rte_flow_get_restore_info() impacts an application performance for drivers that do not provide this ops. It could also impact processing of packets that require no call to rte_flow_get_restore_info() at all. Advertise in mbuf (via a dynamic flag) wh