Re: [RFC 00/11] Fix dev_ops dereferences

2025-02-18 Thread Bruce Richardson
On Mon, Feb 17, 2025 at 09:24:04PM +0100, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, 17 February 2025 19.54 > > > > A common pattern in DPDK internals is to have an array of function > > pointers. When using these pointers an unnecessary

Re: [RFC 00/11] Fix dev_ops dereferences

2025-02-17 Thread Stephen Hemminger
I found a bunch more cases will send V2 On Mon, Feb 17, 2025, 12:24 Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, 17 February 2025 19.54 > > > > A common pattern in DPDK internals is to have an array of function > > pointers. When using th

RE: [RFC 00/11] Fix dev_ops dereferences

2025-02-17 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, 17 February 2025 19.54 > > A common pattern in DPDK internals is to have an array of function > pointers. When using these pointers an unnecessary derefence is done; > this is allowed in C because of a historical quirk b

[RFC 00/11] Fix dev_ops dereferences

2025-02-17 Thread Stephen Hemminger
A common pattern in DPDK internals is to have an array of function pointers. When using these pointers an unnecessary derefence is done; this is allowed in C because of a historical quirk but unnecessary. The PVS Studio checker flags these as: https://pvs-studio.com/en/docs/warnings/v516/ This l