Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Konstantin Ananyev
06/05/2022 17:39, Bruce Richardson пишет: On Fri, May 06, 2022 at 09:33:41AM -0700, Stephen Hemminger wrote: On Fri, 6 May 2022 16:28:41 +0100 Bruce Richardson wrote: On Fri, May 06, 2022 at 03:12:32PM +, Honnappa Nagarahalli wrote: On Thu, May 05, 2022 at 10:59:32PM +, Honnappa N

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Bruce Richardson
On Fri, May 06, 2022 at 09:33:41AM -0700, Stephen Hemminger wrote: > On Fri, 6 May 2022 16:28:41 +0100 > Bruce Richardson wrote: > > > On Fri, May 06, 2022 at 03:12:32PM +, Honnappa Nagarahalli wrote: > > > > > > > > > > > On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wro

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Bruce Richardson
On Fri, May 06, 2022 at 08:41:12AM -0700, Stephen Hemminger wrote: > On Fri, 6 May 2022 00:24:34 -0700 > Tyler Retzlaff wrote: > > > On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wrote: > > > Thanks Stephen. Do you see any performance difference with this change? > > > > as a

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Stephen Hemminger
On Fri, 6 May 2022 16:28:41 +0100 Bruce Richardson wrote: > On Fri, May 06, 2022 at 03:12:32PM +, Honnappa Nagarahalli wrote: > > > > > > > > On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wrote: > > > > Thanks Stephen. Do you see any performance difference with this cha

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Stephen Hemminger
On Fri, 6 May 2022 00:24:34 -0700 Tyler Retzlaff wrote: > On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wrote: > > Thanks Stephen. Do you see any performance difference with this change? > > as a matter of due diligence i think a comparison should be made just > to be confiden

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Bruce Richardson
On Fri, May 06, 2022 at 03:12:32PM +, Honnappa Nagarahalli wrote: > > > > > On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wrote: > > > Thanks Stephen. Do you see any performance difference with this change? > > > > as a matter of due diligence i think a comparison should be

RE: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Honnappa Nagarahalli
nks > > > > > > -Original Message- > > > From: Stephen Hemminger > > > Sent: Thursday, May 5, 2022 5:46 PM > > > To: dev@dpdk.org > > > Cc: Stephen Hemminger > > > Subject: [RFC] rte_ring: don't use always inline >

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Tyler Retzlaff
> > From: Stephen Hemminger > > Sent: Thursday, May 5, 2022 5:46 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [RFC] rte_ring: don't use always inline > > > > Forcing compiler to inline with always inline can lead to worse and &

RE: [RFC] rte_ring: don't use always inline

2022-05-05 Thread Honnappa Nagarahalli
> > > Thanks Stephen. Do you see any performance difference with this change? > > > > > -Original Message- > > > From: Stephen Hemminger > > > Sent: Thursday, May 5, 2022 5:46 PM > > > To: dev@dpdk.org > > > Cc: Stephen Hemmi

Re: [RFC] rte_ring: don't use always inline

2022-05-05 Thread Stephen Hemminger
Stephen Hemminger > > > Sent: Thursday, May 5, 2022 5:46 PM > > > To: dev@dpdk.org > > > Cc: Stephen Hemminger > > > Subject: [RFC] rte_ring: don't use always inline > > > > > > Forcing compiler to inline with always inline can lead

Re: [RFC] rte_ring: don't use always inline

2022-05-05 Thread Stephen Hemminger
.org > > Cc: Stephen Hemminger > > Subject: [RFC] rte_ring: don't use always inline > > > > Forcing compiler to inline with always inline can lead to worse and > > sometimes > > broken code. Better to use the standard inline keyword and let compi

RE: [RFC] rte_ring: don't use always inline

2022-05-05 Thread Honnappa Nagarahalli
Thanks Stephen. Do you see any performance difference with this change? > -Original Message- > From: Stephen Hemminger > Sent: Thursday, May 5, 2022 5:46 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [RFC] rte_ring: don't use always inline > > Fo

[RFC] rte_ring: don't use always inline

2022-05-05 Thread Stephen Hemminger
Forcing compiler to inline with always inline can lead to worse and sometimes broken code. Better to use the standard inline keyword and let compiler have some flexibilty. Signed-off-by: Stephen Hemminger --- This is RFC because the use of large scale inlining is debatable. This change may slow