Re: [PATCH v9 3/3] dts: add VLAN methods to testpmd shell

2024-07-09 Thread Jeremy Spewock
Hey Dean, one other thing that I just noticed which I should have picked up on sooner is that all of the methods that you added here are missing return type annotations. I believe these are generally things we look for on all methods, and I'm surprised that we don't have something that checks for t

[PATCH v9 3/3] dts: add VLAN methods to testpmd shell

2024-07-03 Thread Dean Marx
added the following methods to testpmd shell class: vlan set filter on/off, rx vlan add/rm, vlan set strip on/off, port stop/start all/port, tx vlan set/reset, set promisc/verbose fixed: bug in vlan_offload for show port info, removed $ at end of regex Signed-off-by: Dean Marx --- dts/framework/