Re: 答复: 答复: [PATCH v8 12/17] net/r8169: implement Tx path

> > return rte_le_to_cpu_32(opts1); > } > > > Best Wishes, > Howard Wang > > -邮件原件- > 发件人: Thomas Monjalon > 发送时间: 2024年11月19日 15:16 > 收件人: pro_nic_d...@realtek.com; 王颢 > 抄送: dev@dpdk.org; Ferruh Yigit > 主题: Re: 答复: [PATCH v8 12/17] net/

答复: 答复: [PATCH v8 12/17] net/r8169: implement Tx path

; 王颢 抄送: dev@dpdk.org; Ferruh Yigit 主题: Re: 答复: [PATCH v8 12/17] net/r8169: implement Tx path External mail. The change below is replacing 1 rte_smp_rmb with 2 calls, so no it is not what I am asking for. Please could you check how to not calling this function at all? This series is already

Re: 答复: [PATCH v8 12/17] net/r8169: implement Tx path

; txd = &txq->hw_ring[head]; > > status = rtl_get_opts1(txd); > > if (!enable_tx_no_close && (status & DescOwn)) > break; > > ... > } > > Best Regards, > Howard Wang > >

答复: [PATCH v8 12/17] net/r8169: implement Tx path

... } Best Regards, Howard Wang -邮件原件- 发件人: Thomas Monjalon 发送时间: 2024年11月18日 22:59 收件人: pro_nic_d...@realtek.com; 王颢 抄送: dev@dpdk.org; Ferruh Yigit 主题: Re: [PATCH v8 12/17] net/r8169: implement Tx path External mail. Hello, 13/11/2024 10:28, Howard Wang: > +static u32 &

答复: [PATCH v8 12/17] net/r8169: implement Tx path

Dear Thomas, I will consider that. By the way, should I make the changes and then upload patch v9? Thanks! -邮件原件- 发件人: Thomas Monjalon 发送时间: 2024年11月18日 22:59 收件人: pro_nic_d...@realtek.com; 王颢 抄送: dev@dpdk.org; Ferruh Yigit 主题: Re: [PATCH v8 12/17] net/r8169: implement Tx path

Re: [PATCH v8 12/17] net/r8169: implement Tx path

Hello, 13/11/2024 10:28, Howard Wang: > +static u32 > +rtl_get_opts1(struct rtl_tx_desc *txd) > +{ > + rte_smp_rmb(); > + > + return rte_le_to_cpu_32(txd->opts1); > +} We should avoid using such heavy memory barrier. Is it possible to use a lighter fence or atomic API?

[PATCH v8 12/17] net/r8169: implement Tx path

Add implementation for TX datapath. Signed-off-by: Howard Wang --- doc/guides/nics/features/r8169.ini | 1 + drivers/net/r8169/r8169_ethdev.c | 6 + drivers/net/r8169/r8169_ethdev.h | 11 + drivers/net/r8169/r8169_rxtx.c | 657 - 4 files changed, 671 inse