RE: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-10-13 Thread Morten Brørup
David, As mentioned below, the first 3 patches in this series [26561] can be considered as individual driver patches. I guess this request was somehow missed. Should I delegate these 3 patches to the respective maintainers for the net-next-xxx trees in Patchwork, or how should I proceed? Patc

RE: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-05-08 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Monday, 6 February 2023 18.29 > > On Mon, Feb 06, 2023 at 05:49:18PM +0100, Morten Brørup wrote: > > > From: David Marchand [mailto:david.march...@redhat.com] > > > Sent: Monday, 6 February 2023 17.11 > > > > > > On Wed, Feb 1, 2

Re: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-04-04 Thread David Marchand
On Tue, Apr 4, 2023 at 4:02 PM Morten Brørup wrote: > > Btw, those were marked as "awaiting upstream", so I suspect someone > > (you maybe?) changed their state manually. > > This state is something used between subtree maintainers and main > > repository. > > Yes, I changed their state, trying t

RE: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-04-04 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Tuesday, 4 April 2023 15.51 > > Hello Morten, > > On Tue, Apr 4, 2023 at 3:42 PM Morten Brørup > wrote: > > > Add nonnull function attribute to help the compiler detect a NULL > > > pointer being passed to a function not acceptin

Re: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-04-04 Thread David Marchand
Hello Morten, On Tue, Apr 4, 2023 at 3:42 PM Morten Brørup wrote: > > Add nonnull function attribute to help the compiler detect a NULL > > pointer being passed to a function not accepting NULL pointers as an > > argument at build time. > > > > Add access function attributes to tell the compiler

RE: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-04-04 Thread Morten Brørup
> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Monday, 16 January 2023 14.07 > > Add nonnull function attribute to help the compiler detect a NULL > pointer being passed to a function not accepting NULL pointers as an > argument at build time. > > Add access function attributes

Re: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-02-06 Thread Tyler Retzlaff
On Mon, Feb 06, 2023 at 05:49:18PM +0100, Morten Brørup wrote: > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Monday, 6 February 2023 17.11 > > > > On Wed, Feb 1, 2023 at 2:16 PM Thomas Monjalon > > wrote: > > > > > I tend to prefer this kind of namespace as well. > > > > >

RE: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-02-06 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Monday, 6 February 2023 17.11 > > On Wed, Feb 1, 2023 at 2:16 PM Thomas Monjalon > wrote: > > > > I tend to prefer this kind of namespace as well. > > > > Let's compare different naming proposals, > > > > taking into account what w

Re: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-02-06 Thread David Marchand
On Wed, Feb 1, 2023 at 2:16 PM Thomas Monjalon wrote: > > > I tend to prefer this kind of namespace as well. > > > Let's compare different naming proposals, > > > taking into account what we already have for some annotations, > > > and what is proposed to be added in this patch and David's patch >

Re: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-02-01 Thread Thomas Monjalon
01/02/2023 13:50, Morten Brørup: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 31/01/2023 19:26, Tyler Retzlaff: > > > On Tue, Jan 31, 2023 at 01:23:34PM +0100, Morten Brørup wrote: > > > > > From: David Marchand [mailto:david.march...@redhat.com] > > > > > On Wed, Jan 18, 2023 at 9:31 A

RE: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-02-01 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, 31 January 2023 23.52 > > 31/01/2023 19:26, Tyler Retzlaff: > > On Tue, Jan 31, 2023 at 01:23:34PM +0100, Morten Brørup wrote: > > > > From: David Marchand [mailto:david.march...@redhat.com] > > > > Sent: Tuesday, 31 January 202

Re: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-01-31 Thread Thomas Monjalon
31/01/2023 19:26, Tyler Retzlaff: > On Tue, Jan 31, 2023 at 01:23:34PM +0100, Morten Brørup wrote: > > > From: David Marchand [mailto:david.march...@redhat.com] > > > Sent: Tuesday, 31 January 2023 12.15 > > > > > > On Wed, Jan 18, 2023 at 9:31 AM Morten Brørup > > > wrote: > > > > > > > > +To: T

Re: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-01-31 Thread Tyler Retzlaff
On Tue, Jan 31, 2023 at 01:23:34PM +0100, Morten Brørup wrote: > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Tuesday, 31 January 2023 12.15 > > > > On Wed, Jan 18, 2023 at 9:31 AM Morten Brørup > > wrote: > > > > > > +To: Thomas & David, you probably have some opinions on

RE: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-01-31 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Tuesday, 31 January 2023 12.15 > > On Wed, Jan 18, 2023 at 9:31 AM Morten Brørup > wrote: > > > > +To: Thomas & David, you probably have some opinions on this too! > > > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com

Re: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-01-31 Thread David Marchand
On Wed, Jan 18, 2023 at 9:31 AM Morten Brørup wrote: > > +To: Thomas & David, you probably have some opinions on this too! > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Tuesday, 17 January 2023 22.17 > > > > On Tue, Jan 17, 2023 at 09:19:22AM +0100, Morten Brørup wrot

Re: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-01-18 Thread Stephen Hemminger
On Wed, 18 Jan 2023 09:31:42 +0100 Morten Brørup wrote: > > > So I decided for this order in the names (treating > > nonnull/access_mode as "country" and param/params as "city"), also > > somewhat looking at the __rte_deprecated and __rte_deprecated_msg(msg) > > macros. > > > > > > I have no

RE: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-01-18 Thread Morten Brørup
+To: Thomas & David, you probably have some opinions on this too! > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Tuesday, 17 January 2023 22.17 > > On Tue, Jan 17, 2023 at 09:19:22AM +0100, Morten Brørup wrote: > > > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > > > Sen

Re: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-01-17 Thread Tyler Retzlaff
On Tue, Jan 17, 2023 at 09:19:22AM +0100, Morten Brørup wrote: > > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > > Sent: Monday, 16 January 2023 18.02 > > > > On 1/16/2023 1:07 PM, Morten Brørup wrote: > > > Add nonnull function attribute to help the compiler detect a NULL > > > pointer being

RE: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-01-17 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Monday, 16 January 2023 18.02 > > On 1/16/2023 1:07 PM, Morten Brørup wrote: > > Add nonnull function attribute to help the compiler detect a NULL > > pointer being passed to a function not accepting NULL pointers as an > > argument at bui

Re: [PATCH v7 4/4] eal: add nonnull and access function attributes

2023-01-16 Thread Ferruh Yigit
On 1/16/2023 1:07 PM, Morten Brørup wrote: > Add nonnull function attribute to help the compiler detect a NULL > pointer being passed to a function not accepting NULL pointers as an > argument at build time. > > Add access function attributes to tell the compiler how a function > accesses memory p

[PATCH v7 4/4] eal: add nonnull and access function attributes

2023-01-16 Thread Morten Brørup
Add nonnull function attribute to help the compiler detect a NULL pointer being passed to a function not accepting NULL pointers as an argument at build time. Add access function attributes to tell the compiler how a function accesses memory pointed to by its pointer arguments. Add these attribut