Re: [PATCH v7 2/3] log: separate logging functions out of EAL

2023-08-09 Thread Bruce Richardson
On Wed, Aug 09, 2023 at 02:24:09PM +0200, David Marchand wrote: > Sorry, two additional comments after running more checks. > > lib/log files are not referenced in MAINTAINERS, can you add a new block? > Yep. > > diff --git a/lib/log/meson.build b/lib/log/meson.build > > new file mode 100644 > >

Re: [PATCH v7 2/3] log: separate logging functions out of EAL

2023-08-09 Thread David Marchand
Sorry, two additional comments after running more checks. lib/log files are not referenced in MAINTAINERS, can you add a new block? > diff --git a/lib/log/meson.build b/lib/log/meson.build > new file mode 100644 > index 00..6baff83ee5 > --- /dev/null > +++ b/lib/log/meson.build > @@ -0,0

Re: [PATCH v7 2/3] log: separate logging functions out of EAL

2023-08-09 Thread David Marchand
Some nits on the doc (that I can fix when applying if you are ok with them) : On Mon, Jul 31, 2023 at 5:39 PM Bruce Richardson wrote: > diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst > b/doc/guides/prog_guide/env_abstraction_layer.rst > index 93c8a031be..8033f6cebd 100644 > --- a/d

Re: [PATCH v7 2/3] log: separate logging functions out of EAL

2023-08-09 Thread Bruce Richardson
On Mon, Jul 31, 2023 at 05:29:04PM +0100, Bruce Richardson wrote: > On Mon, Jul 31, 2023 at 06:22:40PM +0200, David Marchand wrote: > > On Mon, Jul 31, 2023 at 5:39 PM Bruce Richardson > > wrote: > > > diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in > > > index 1a4210b948..40f7dd2

Re: [PATCH v7 2/3] log: separate logging functions out of EAL

2023-07-31 Thread Bruce Richardson
On Mon, Jul 31, 2023 at 06:22:40PM +0200, David Marchand wrote: > On Mon, Jul 31, 2023 at 5:39 PM Bruce Richardson > wrote: > > diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in > > index 1a4210b948..40f7dd2877 100644 > > --- a/doc/api/doxy-api.conf.in > > +++ b/doc/api/doxy-api.con

Re: [PATCH v7 2/3] log: separate logging functions out of EAL

2023-07-31 Thread David Marchand
On Mon, Jul 31, 2023 at 5:39 PM Bruce Richardson wrote: > diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in > index 1a4210b948..40f7dd2877 100644 > --- a/doc/api/doxy-api.conf.in > +++ b/doc/api/doxy-api.conf.in > @@ -52,6 +52,7 @@ INPUT = > @TOPDIR@/doc/api/doxy-

[PATCH v7 2/3] log: separate logging functions out of EAL

2023-07-31 Thread Bruce Richardson
Move the logging capability to a separate library, free from EAL. Rename files as appropriate, and use meson.build to select the correct file to be built for each operating system, rather than having a subdir per-os. Add new documentation section in programmers guide to cover logging in more detail