Re: [PATCH v7] ethdev: add template table resize API

2024-02-14 Thread Etelson, Gregory
Hello Ferruh, <...> Syntax above is odd, why not move parenthesis to first line. Agree that's odd style. DPDK prefers that way. Please check rte_flow_driver.h::rte_flow.ops. True that is also odd but at least it is function pointers in a struct, but this is regular function deceleration, w

Re: [PATCH v7] ethdev: add template table resize API

2024-02-14 Thread Ferruh Yigit
On 2/14/2024 5:07 PM, Etelson, Gregory wrote: > Hello Ferruh, > >> >> Having conflict while applying the patch, can you please rebase it on >> latest 'next-net'? > > Will rebase and update the patch. > >> >>> +    Query wheather template table can be resized. >>> >> >> s/wheather/whether/ >> >>

Re: [PATCH v7] ethdev: add template table resize API

2024-02-14 Thread Etelson, Gregory
Hello Ferruh, Having conflict while applying the patch, can you please rebase it on latest 'next-net'? Will rebase and update the patch. +Query wheather template table can be resized. s/wheather/whether/ <...> fix in updated patch +__rte_experimental +bool +rte_flow_template

Re: [PATCH v7] ethdev: add template table resize API

2024-02-14 Thread Ferruh Yigit
On 2/14/2024 2:32 PM, Gregory Etelson wrote: > Template table creation API sets table flows capacity. > If application needs more flows then the table was designed for, > the following procedures must be completed: > 1. Create a new template table with larger flows capacity. > 2. Re-create existing

Re: [PATCH v7] ethdev: add template table resize API

2024-02-14 Thread Thomas Monjalon
14/02/2024 15:32, Gregory Etelson: > +The resizable template table API enables applications to dynamically adjust > +capacity of template tables without disrupting the existing flow rules > +operation. The resizable template table API allows applications to optimize > the > +memory usage and perfo

[PATCH v7] ethdev: add template table resize API

2024-02-14 Thread Gregory Etelson
Template table creation API sets table flows capacity. If application needs more flows then the table was designed for, the following procedures must be completed: 1. Create a new template table with larger flows capacity. 2. Re-create existing flows in the new table and delete flows from the or