Re: [PATCH v6 00/30] fix packing of structs when building with MSVC

2024-12-23 Thread Andre Muezerie
On Mon, Dec 23, 2024 at 12:46:34PM +0100, David Marchand wrote: > On Mon, Dec 23, 2024 at 12:03 PM David Marchand > wrote: > > > v6: > > > * replace __rte_msvc_pack with __rte_packed_begin > > > * replace __rte_packed with __rte_packed_end > > > * update checkpatches.sh to ensure __rte_packe

Re: [PATCH v6 00/30] fix packing of structs when building with MSVC

2024-12-23 Thread David Marchand
On Mon, Dec 23, 2024 at 12:03 PM David Marchand wrote: > > v6: > > * replace __rte_msvc_pack with __rte_packed_begin > > * replace __rte_packed with __rte_packed_end > > * update checkpatches.sh to ensure __rte_packed_begin and > > __rte_packed_end are used in pairs > > I had mentionned

Re: [PATCH v6 00/30] fix packing of structs when building with MSVC

2024-12-23 Thread David Marchand
Hello Andre, On Wed, Nov 27, 2024 at 1:53 AM Andre Muezerie wrote: > > MSVC struct packing is not compatible with GCC. Provide a macro > (__rte_packed_begin) that can be used to push existing pack value > and sets packing to 1-byte. The existing __rte_packed macro is > replaced with __rte_packed_

[PATCH v6 00/30] fix packing of structs when building with MSVC

2024-11-26 Thread Andre Muezerie
MSVC struct packing is not compatible with GCC. Provide a macro (__rte_packed_begin) that can be used to push existing pack value and sets packing to 1-byte. The existing __rte_packed macro is replaced with __rte_packed_end and restores the pack value prior to the push. Instead of providing macros