Re:Re: [PATCH v6] ip_frag: add IPv4 options fragment and test data

2022-04-14 Thread Huichao Cai
>No sorry, it cannot be applied as-is. > >Some IP constants should be defined in lib/net/rte_ip.h >and should be named RTE_IPV4_HDR_OPT_* for consistency. Ok,I will modify it and resubmit the patch.Thanks.

Re: [PATCH v6] ip_frag: add IPv4 options fragment and test data

2022-04-14 Thread Thomas Monjalon
14/04/2022 15:14, Thomas Monjalon: > 11/04/2022 05:55, Huichao Cai: > > According to RFC791,the options may appear or not in datagrams. > > They must be implemented by all IP modules (host and gateways). > > What is optional is their transmission in any particular datagram, > > not their implementa

Re: [PATCH v6] ip_frag: add IPv4 options fragment and test data

2022-04-14 Thread Thomas Monjalon
11/04/2022 05:55, Huichao Cai: > According to RFC791,the options may appear or not in datagrams. > They must be implemented by all IP modules (host and gateways). > What is optional is their transmission in any particular datagram, > not their implementation.So we have to deal with it during the >

[PATCH v6] ip_frag: add IPv4 options fragment and test data

2022-04-10 Thread Huichao Cai
According to RFC791,the options may appear or not in datagrams. They must be implemented by all IP modules (host and gateways). What is optional is their transmission in any particular datagram, not their implementation.So we have to deal with it during the fragmenting process.Add some test data fo