RE: [PATCH v5 1/2] lib/fib: remove warning about implicit 64-bit conversion

2025-05-17 Thread Morten Brørup
From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Saturday, 17 May 2025 13.10 Ok. Wonder if RTE_PTR_ADD should have the cast there instead  Morten: Considered the same; but prefer not. It will suppress warnings like this, which may be real. On Sat, May 17, 2025, 05:45 Andre Mu

Re: [PATCH v5 1/2] lib/fib: remove warning about implicit 64-bit conversion

2025-05-17 Thread Stephen Hemminger
Ok. Wonder if RTE_PTR_ADD should have the cast there instead On Sat, May 17, 2025, 05:45 Andre Muezerie wrote: > MSVC issues the warning below: > > ../lib/fib/trie.c(341): warning C4334: '<<': > result of 32-bit shift implicitly converted to 64 bits > (was 64-bit shift intended?) > > The fix is

RE: [PATCH v5 1/2] lib/fib: remove warning about implicit 64-bit conversion

2025-05-17 Thread Morten Brørup
> From: Andre Muezerie [mailto:andre...@linux.microsoft.com] > Sent: Friday, 16 May 2025 22.46 > > MSVC issues the warning below: > > ../lib/fib/trie.c(341): warning C4334: '<<': > result of 32-bit shift implicitly converted to 64 bits > (was 64-bit shift intended?) > > The fix is to cast (1) ex

[PATCH v5 1/2] lib/fib: remove warning about implicit 64-bit conversion

2025-05-16 Thread Andre Muezerie
MSVC issues the warning below: ../lib/fib/trie.c(341): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) The fix is to cast (1) explicitly to uintptr_t since it is used in pointer arithmetic. Signed-off-by: Andre Muezerie --- lib/fib/trie.