Re: [PATCH v5 0/3] add portable version of __builtin_add_overflow

2025-06-04 Thread Thomas Monjalon
04/06/2025 13:04, Morten Brørup: > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Wednesday, 4 June 2025 12.41 > > > > On Wed, Jun 4, 2025 at 12:29 PM Morten Brørup > > wrote: > > > > I am not a fan of adding such public API, an internal API would be > > > > enough. > > > > D

RE: [PATCH v5 0/3] add portable version of __builtin_add_overflow

2025-06-04 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, 4 June 2025 12.41 > > On Wed, Jun 4, 2025 at 12:29 PM Morten Brørup > wrote: > > > I am not a fan of adding such public API, an internal API would be > > > enough. > > > Do you plan to add more helpers for math operation

Re: [PATCH v5 0/3] add portable version of __builtin_add_overflow

2025-06-04 Thread David Marchand
On Wed, Jun 4, 2025 at 12:29 PM Morten Brørup wrote: > > I am not a fan of adding such public API, an internal API would be > > enough. > > Do you plan to add more helpers for math operations? > > > > For the current helper, the only user is a driver (base code). > > Can't we just wrap a __builti

RE: [PATCH v5 0/3] add portable version of __builtin_add_overflow

2025-06-04 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, 4 June 2025 12.08 > > On Fri, Mar 14, 2025 at 3:34 PM Andre Muezerie > wrote: > > > > __builtin_add_overflow is gcc specific. There's a need for a portable > > version that can also be used with other compilers. > > > >

Re: [PATCH v5 0/3] add portable version of __builtin_add_overflow

2025-06-04 Thread David Marchand
On Fri, Mar 14, 2025 at 3:34 PM Andre Muezerie wrote: > > __builtin_add_overflow is gcc specific. There's a need for a portable > version that can also be used with other compilers. > > v5: > - Combined patches 1 with 5 and 2 with 3. > > v4: > - Added define in ice_osdep.h to use portable version

[PATCH v5 0/3] add portable version of __builtin_add_overflow

2025-03-14 Thread Andre Muezerie
__builtin_add_overflow is gcc specific. There's a need for a portable version that can also be used with other compilers. v5: - Combined patches 1 with 5 and 2 with 3. v4: - Added define in ice_osdep.h to use portable version of __builtin_add_overflow when using MSVC. - Undid all changes from d