RE: [EXT] Re: [PATCH v5] app/mldev: add internal function for file read

2023-06-07 Thread Srikanth Yalavarthi
> -Original Message- > From: Stephen Hemminger > Sent: 07 June 2023 22:19 > To: Srikanth Yalavarthi > Cc: Anup Prabhu ; dev@dpdk.org; Shivah Shankar > Shankar Narayan Rao ; Prince Takkar > > Subject: [EXT] Re: [PATCH v5] app/mldev: add internal function for file

Re: [PATCH v5] app/mldev: add internal function for file read

2023-06-07 Thread Stephen Hemminger
On Wed, 7 Jun 2023 09:20:30 -0700 Srikanth Yalavarthi wrote: The normal case leaks the open file descriptor + + file_map = mmap(0, file_stat.st_size, PROT_READ, MAP_PRIVATE, fd, 0); + if (file_map == MAP_FAILED) { + ml_err("Failed to map file: %s\n", file); +

[PATCH v5] app/mldev: add internal function for file read

2023-06-07 Thread Srikanth Yalavarthi
Added internal function to read model, input and reference files with required error checks. This change fixes the unchecked return value and improper use of negative value issues reported by coverity scan for file read operations. Coverity issue: 383742, 383743 Fixes: f6661e6d9a3a ("app/mldev: va