Re: [PATCH v4 3/4] dts: add methods for modifying MTU to testpmd shell

2024-06-21 Thread Juraj Linkeš
+func: Callable[["TestPmdShell", int, Any, bool], None] I'm thinking about this type. Sounds like there are too many conditions that need to be satisfied. The problem is with the verify parameter. Do we actually need it? If we're decorating a function, that may imply we always want to ver

Re: [PATCH v4 3/4] dts: add methods for modifying MTU to testpmd shell

2024-06-20 Thread Jeremy Spewock
On Wed, Jun 19, 2024 at 4:16 AM Juraj Linkeš wrote: > > > > +def stop_then_start_port_decorator( > > The name shouldn't contain "decorator". Just the docstring should > mention it's a decorator. Ack. > > > +func: Callable[["TestPmdShell", int, Any, bool], None] > > I'm thinking about this ty

Re: [PATCH v4 3/4] dts: add methods for modifying MTU to testpmd shell

2024-06-19 Thread Juraj Linkeš
+def stop_then_start_port_decorator( The name shouldn't contain "decorator". Just the docstring should mention it's a decorator. +func: Callable[["TestPmdShell", int, Any, bool], None] I'm thinking about this type. Sounds like there are too many conditions that need to be satisfied

[PATCH v4 3/4] dts: add methods for modifying MTU to testpmd shell

2024-06-13 Thread jspewock
From: Jeremy Spewock There are methods within DTS currently that support updating the MTU of ports on a node, but the methods for doing this in a linux session rely on the ip command and the port being bound to the kernel driver. Since test suites are run while bound to the driver for DPDK, there