RE: [PATCH v4 10/10] common/dpaxx: remove zero length array

2023-11-27 Thread Hemant Agrawal
Acked-by: Hemant Agrawal > -Original Message- > From: Stephen Hemminger > Sent: Friday, November 24, 2023 12:49 AM > To: Hemant Agrawal > Cc: Tyler Retzlaff ; dev@dpdk.org; Sachin > Saxena ; Gagandeep Singh > Subject: Re: [PATCH v4 10/10] common/dpaxx: rem

Re: [PATCH v4 10/10] common/dpaxx: remove zero length array

2023-11-24 Thread Stephen Hemminger
This is a better alternative. From 52c805b9526dbef62377276c4499c997fbc96268 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 23 Nov 2023 11:12:02 -0800 Subject: [PATCH] common/dpaxx: replace zero length array The zero length ip_header is used as an overlay to the encap IP header. Sinc

Re: [PATCH v4 10/10] common/dpaxx: remove zero length array

2023-11-22 Thread Stephen Hemminger
gh > > Subject: Re: [PATCH v4 10/10] common/dpaxx: remove zero length array > > Importance: High > > > > On Tue, Nov 21, 2023 at 08:46:41AM -0800, Stephen Hemminger wrote: > > > On Tue, 21 Nov 2023 10:49:59 + > > > Hemant Agrawal wrote

RE: [PATCH v4 10/10] common/dpaxx: remove zero length array

2023-11-21 Thread Hemant Agrawal
> -Original Message- > From: Tyler Retzlaff > Sent: Tuesday, November 21, 2023 10:49 PM > To: Stephen Hemminger > Cc: Hemant Agrawal ; dev@dpdk.org; Sachin > Saxena ; Gagandeep Singh > Subject: Re: [PATCH v4 10/10] common/dpaxx: remove zero length array > Impo

Re: [PATCH v4 10/10] common/dpaxx: remove zero length array

2023-11-21 Thread Tyler Retzlaff
On Tue, Nov 21, 2023 at 08:46:41AM -0800, Stephen Hemminger wrote: > On Tue, 21 Nov 2023 10:49:59 + > Hemant Agrawal wrote: > > > > struct ipsec_encap_pdb { > > > uint32_t options; > > > @@ -350,7 +349,6 @@ struct ipsec_encap_pdb { > > > }; > > > uint32_t spi; > > > uint32_t ip_hdr_l

Re: [PATCH v4 10/10] common/dpaxx: remove zero length array

2023-11-21 Thread Stephen Hemminger
On Tue, 21 Nov 2023 08:46:41 -0800 Stephen Hemminger wrote: > On Tue, 21 Nov 2023 10:49:59 + > Hemant Agrawal wrote: > > > > struct ipsec_encap_pdb { > > > uint32_t options; > > > @@ -350,7 +349,6 @@ struct ipsec_encap_pdb { > > > }; > > > uint32_t spi; > > > uint32_t ip_hdr_len; >

Re: [PATCH v4 10/10] common/dpaxx: remove zero length array

2023-11-21 Thread Stephen Hemminger
On Tue, 21 Nov 2023 10:49:59 + Hemant Agrawal wrote: > > struct ipsec_encap_pdb { > > uint32_t options; > > @@ -350,7 +349,6 @@ struct ipsec_encap_pdb { > > }; > > uint32_t spi; > > uint32_t ip_hdr_len; > > - uint8_t ip_hdr[0]; > [Hemant] This should be replaced with >

RE: [PATCH v4 10/10] common/dpaxx: remove zero length array

2023-11-21 Thread Hemant Agrawal
> There is a place holder zero length array in this driver. > But since the structure is embedded in other structures, > it could not have been safely used anyway. > There doesn't appear to be any uses of it in the current code. > > Signed-off-by: Stephen Hemminger > --- > drivers/common/dpaax/c

[PATCH v4 10/10] common/dpaxx: remove zero length array

2023-11-20 Thread Stephen Hemminger
There is a place holder zero length array in this driver. But since the structure is embedded in other structures, it could not have been safely used anyway. There doesn't appear to be any uses of it in the current code. Signed-off-by: Stephen Hemminger --- drivers/common/dpaax/caamflib/desc/ips