RE: [EXTERNAL] Re: [PATCH v4 1/5] graph: add support for node specific errors

2024-10-11 Thread Pavan Nikhilesh Bhagavatula
> On Fri, Aug 16, 2024 at 5:10 PM wrote: > > > > From: Pavan Nikhilesh > > > > Add ability for Nodes to advertise error counters > > during registration. > > > > Signed-off-by: Pavan Nikhilesh > > Such a series deserve a cover letter. > > It also deserves a RN update, and I see no removal of t

RE: [EXTERNAL] Re: [PATCH v4 1/5] graph: add support for node specific errors

2024-10-11 Thread Pavan Nikhilesh Bhagavatula
> I forgot to mention. > > If you submit a v5, could you squash all commits that deal with > lib/graph into a single patch? Including the public API to increment the > nodes xstats? I will squash (2/5, 3/5), (4/5, 5/5) and leave 1/5 alone as it is a very big patch containing updates to svg fil

Re: [PATCH v4 1/5] graph: add support for node specific errors

2024-10-11 Thread David Marchand
On Fri, Aug 16, 2024 at 5:10 PM wrote: > > From: Pavan Nikhilesh > > Add ability for Nodes to advertise error counters > during registration. > > Signed-off-by: Pavan Nikhilesh Such a series deserve a cover letter. It also deserves a RN update, and I see no removal of the associated deprecatio

Re: [PATCH v4 1/5] graph: add support for node specific errors

2024-10-11 Thread Robin Jarry
I forgot to mention. If you submit a v5, could you squash all commits that deal with lib/graph into a single patch? Including the public API to increment the nodes xstats? And a second patch that implements xstats in the in-built nodes. Thanks!

Re: [PATCH v4 1/5] graph: add support for node specific errors

2024-10-11 Thread Robin Jarry
Hi Pavan, , Aug 16, 2024 at 17:09: From: Pavan Nikhilesh Add ability for Nodes to advertise error counters during registration. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Fix compilation. v3 Changes: - Resend as 1/5 didn't make it through. v4 Changes: - Address review comments. - Rebas

Re: [PATCH v4 1/5] graph: add support for node specific errors

2024-10-08 Thread David Marchand
dda > > ; zhirun@intel.com; Zhirun Yan > > > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > Subject: [PATCH v4 1/5] graph: add support for node specific errors > > > > From: Pavan Nikhilesh > > > > Add ability for Nodes to advertise