Re: [PATCH v4 1/2] testpmd: go back to using cmdline_interact

2023-03-17 Thread Stephen Hemminger
On Fri, 17 Mar 2023 17:20:48 +0100 Olivier Matz wrote: > > > > +#ifdef RTE_EXEC_ENV_WINDOWS > > signal(SIGINT, signal_handler); > > signal(SIGTERM, signal_handler); > > +#else > > + /* Want read() not to be restarted on signal */ > > + struct sigaction action = { > > + .sa

Re: [PATCH v4 1/2] testpmd: go back to using cmdline_interact

2023-03-17 Thread Olivier Matz
Hi Stephen, Thank you for having a look at this. On Wed, Mar 15, 2023 at 10:31:31AM -0700, Stephen Hemminger wrote: > The cmdline library poll function is broken on Windows > and was never tested, don't use it. > > Instead, use sigaction() to cancel read character on Unix OS's > and a new helper

[PATCH v4 1/2] testpmd: go back to using cmdline_interact

2023-03-15 Thread Stephen Hemminger
The cmdline library poll function is broken on Windows and was never tested, don't use it. Instead, use sigaction() to cancel read character on Unix OS's and a new helper to cancel I/O on Windows. Fixes: 0fd1386c30c3 ("app/testpmd: cleanup cleanly from signal") Bugzilla ID: 1180 Signed-off-by: St