Re: [PATCH v4] eventdev: ensure 16-byte alignment for events

2024-01-19 Thread Tyler Retzlaff
On Mon, Nov 13, 2023 at 08:58:19AM +0100, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Monday, 13 November 2023 00.32 > > > > On Sun, 12 Nov 2023 09:30:24 +0100 > > Morten Brørup wrote: > > > > > > > +static_assert(sizeof(struct rte_event) == 16,

RE: [PATCH v4] eventdev: ensure 16-byte alignment for events

2023-11-12 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Monday, 13 November 2023 00.32 > > On Sun, 12 Nov 2023 09:30:24 +0100 > Morten Brørup wrote: > > > > > +static_assert(sizeof(struct rte_event) == 16, "Event structure > size > > > is not 16-bytes in size"); > > > > + > > > >

Re: [PATCH v4] eventdev: ensure 16-byte alignment for events

2023-11-12 Thread Stephen Hemminger
On Sun, 12 Nov 2023 09:30:24 +0100 Morten Brørup wrote: > > > +static_assert(sizeof(struct rte_event) == 16, "Event structure size > > is not 16-bytes in size"); > > > + > > > static struct rte_eventdev rte_event_devices[RTE_EVENT_MAX_DEVS]; > > > > Please don't reinvent RTE_BUILD_BUG_ON(

RE: [PATCH v4] eventdev: ensure 16-byte alignment for events

2023-11-12 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Sunday, 12 November 2023 01.01 > > On Fri, 6 Oct 2023 11:29:32 +0100 > Bruce Richardson wrote: > > > diff --git a/lib/eventdev/rte_eventdev.c > b/lib/eventdev/rte_eventdev.c > > index 95373bbaad..adc9751cef 100644 > > --- a/l

Re: [PATCH v4] eventdev: ensure 16-byte alignment for events

2023-11-11 Thread Stephen Hemminger
On Fri, 6 Oct 2023 11:29:32 +0100 Bruce Richardson wrote: > diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c > index 95373bbaad..adc9751cef 100644 > --- a/lib/eventdev/rte_eventdev.c > +++ b/lib/eventdev/rte_eventdev.c > @@ -9,6 +9,7 @@ > #include > #include > #include

[PATCH v4] eventdev: ensure 16-byte alignment for events

2023-10-06 Thread Bruce Richardson
The event structure in DPDK is 16-bytes in size, and events are regularly passed as parameters directly rather than being passed as pointers. To help compiler optimize correctly, we can explicitly request 16-byte alignment for events, which means that we should be able to do aligned vector loads/st