Re: [PATCH v3 8/8] dts: use Unpack for type checking and hinting

2024-06-06 Thread Juraj Linkeš
On 30. 5. 2024 17:25, Luca Vizzarro wrote: Interactive shells that inherit DPDKShell initialise their params classes from a kwargs dict. Therefore, static type checking is disabled. This change uses the functionality of Unpack added in PEP 692 to re-enable it. The disadvantage is that this fun

Re: [PATCH v3 8/8] dts: use Unpack for type checking and hinting

2024-05-31 Thread Nicholas Pratte
Tested-by: Nicholas Pratte Reviewed-by: Nicholas Pratte On Thu, May 30, 2024 at 11:25 AM Luca Vizzarro wrote: > > Interactive shells that inherit DPDKShell initialise their params > classes from a kwargs dict. Therefore, static type checking is > disabled. This change uses the functionality of

Re: [PATCH v3 8/8] dts: use Unpack for type checking and hinting

2024-05-30 Thread Jeremy Spewock
Reviewed-by: Jeremy Spewock

[PATCH v3 8/8] dts: use Unpack for type checking and hinting

2024-05-30 Thread Luca Vizzarro
Interactive shells that inherit DPDKShell initialise their params classes from a kwargs dict. Therefore, static type checking is disabled. This change uses the functionality of Unpack added in PEP 692 to re-enable it. The disadvantage is that this functionality has been implemented only with TypedD