Re: [EXT] [PATCH v3 5/9] trace: fix dynamically enabling trace points

2022-10-14 Thread Jerin Jacob
On Fri, Oct 14, 2022 at 1:49 PM David Marchand wrote: > > On Fri, Oct 14, 2022 at 6:27 AM Jerin Jacob wrote: > > > > On Fri, Oct 14, 2022 at 12:41 AM David Marchand > > wrote: > > > > > > On Thu, Oct 13, 2022 at 7:07 PM Harman Kalra wrote: > > > > > > > > > > With the whole traces fixes series

Re: [EXT] [PATCH v3 5/9] trace: fix dynamically enabling trace points

2022-10-14 Thread David Marchand
On Fri, Oct 14, 2022 at 6:27 AM Jerin Jacob wrote: > > On Fri, Oct 14, 2022 at 12:41 AM David Marchand > wrote: > > > > On Thu, Oct 13, 2022 at 7:07 PM Harman Kalra wrote: > > > > > > > > With the whole traces fixes series applied first, then the new "trace: > > > > take live traces via telemetr

Re: [EXT] [PATCH v3 5/9] trace: fix dynamically enabling trace points

2022-10-13 Thread Jerin Jacob
On Fri, Oct 14, 2022 at 12:41 AM David Marchand wrote: > > On Thu, Oct 13, 2022 at 7:07 PM Harman Kalra wrote: > > > > > > With the whole traces fixes series applied first, then the new "trace: > > > take live traces via telemetry" patch applied, I can't reproduce your > > > issue. > > > > > > >

Re: [EXT] [PATCH v3 5/9] trace: fix dynamically enabling trace points

2022-10-13 Thread David Marchand
On Thu, Oct 13, 2022 at 7:07 PM Harman Kalra wrote: > > > > With the whole traces fixes series applied first, then the new "trace: > > take live traces via telemetry" patch applied, I can't reproduce your issue. > > > > > > Yes, you replicated the same scenario what I tried. > Sorry, I realized th

RE: [EXT] [PATCH v3 5/9] trace: fix dynamically enabling trace points

2022-10-13 Thread Harman Kalra
> -Original Message- > From: David Marchand > Sent: Thursday, October 13, 2022 9:22 PM > To: Harman Kalra > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Sunil > Kumar Kori ; sta...@dpdk.org > Subject: Re: [EXT] [PATCH v3 5/9] trace: fix dynamically enabling tra

Re: [EXT] [PATCH v3 5/9] trace: fix dynamically enabling trace points

2022-10-13 Thread David Marchand
On Thu, Oct 13, 2022 at 4:53 PM Harman Kalra wrote: > > > > -int > > +static int > > trace_mkdir(void) > > { > > struct trace *trace = trace_obj_get(); > > char session[TRACE_DIR_STR_LEN]; > > + static bool already_done; > > char *dir_path; > > int rc; > > > > + i

RE: [EXT] [PATCH v3 5/9] trace: fix dynamically enabling trace points

2022-10-13 Thread Harman Kalra
> -int > +static int > trace_mkdir(void) > { > struct trace *trace = trace_obj_get(); > char session[TRACE_DIR_STR_LEN]; > + static bool already_done; > char *dir_path; > int rc; > > + if (already_done) > + return 0; > + Hi David I was trying out "t

[PATCH v3 5/9] trace: fix dynamically enabling trace points

2022-10-12 Thread David Marchand
Enabling trace points at runtime was not working if no trace point had been enabled first at rte_eal_init() time. The reason was that trace.args reflected the arguments passed to --trace= EAL option. To fix this: - the trace subsystem initialisation is updated: trace directory creation is deferr